-
Notifications
You must be signed in to change notification settings - Fork 7
sdk method for Add file and directory #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cd79c78
sdk method for Add file and directory
PrasadhNanjundan05 37892f5
CCLA-848: import json on file level
PrasadhNanjundan05 46db285
CCLA-848: import json on file level
PrasadhNanjundan05 7b9d1b6
CCLA-848: import json on file level
PrasadhNanjundan05 8ea0d38
sdk method for sync me async and get status
PrasadhNanjundan05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this API should be deprecated, and we should use a real upload API with multipart content. This method may pose serious problem with bianry content.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is used in WF file editor, BPM editor .. since those are from editor, I guess we cannot use mulipart content. probably we can limit the content size, sanitize the input path and other security checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably I guess we should restrict this kind of API to be only allowed to call only from our UI. not directly, just thinking out loud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean, is we are going to propose a
add_fileapi, the idea is to do it correctly. The fact that UI is using this buggy API is another problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
I am note sure for UI.
Every people on UI should know that you upload things with multi part, so having a 100% in house way to upload things seems to be more a problem than a solution.
I think UI libraries should as default be compatible with multi part upload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vignaudo I created a ticket to address this in the next release - https://jiras.ubiqube.com/browse/MSA-14797