sdk method for Add file and directory #119
Conversation
| """ | ||
| self.action = 'Add file content' | ||
| url_encoded = urlencode({'uri': file_uri}) | ||
| self.path = "{}/file?{}".format(self.api_path, url_encoded) |
There was a problem hiding this comment.
I think this API should be deprecated, and we should use a real upload API with multipart content. This method may pose serious problem with bianry content.
There was a problem hiding this comment.
This API is used in WF file editor, BPM editor .. since those are from editor, I guess we cannot use mulipart content. probably we can limit the content size, sanitize the input path and other security checks
There was a problem hiding this comment.
Probably I guess we should restrict this kind of API to be only allowed to call only from our UI. not directly, just thinking out loud
There was a problem hiding this comment.
What I mean, is we are going to propose a add_file api, the idea is to do it correctly. The fact that UI is using this buggy API is another problem.
There was a problem hiding this comment.
Note:
I am note sure for UI.
Every people on UI should know that you upload things with multi part, so having a 100% in house way to upload things seems to be more a problem than a solution.
I think UI libraries should as default be compatible with multi part upload.
There was a problem hiding this comment.
@Vignaudo I created a ticket to address this in the next release - https://jiras.ubiqube.com/browse/MSA-14797
PrasadhNanjundan05
force-pushed
the
3.2.1/CCLA-848
branch
from
b767737 to
37892f5
Compare
PrasadhNanjundan05
force-pushed
the
3.2.1/CCLA-848
branch
from
d4299a1 to
8ea0d38
Compare
No description provided.