Upmerge changes from hoogle.haskell.org #468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And eliminate partiality in mode handlers.
This was referenced Jan 27, 2026
|
Maybe we don't need it anymore but since it's pinned either way it seems unnecessary to change it, if hoogle itself doesn't need it. |
|
I will run a quick build and see if everything's okay and if it is, we can just accept it as is. |
|
hackage-revdeps seems like it is too old with the new changes to hoogle. I will try to prepare a patch in the following days :) |
|
@Bodigrim, will you tell me when this is ready to be deployed? Or can I just do it as soon as this MR is merged? |
Collaborator
Author
|
Sure, I'll update you once ready. (Ben switched to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is https://github.com/bgamari/hoogle/tree/h-o-deployment rebased.
@MangoIV could you please review Nix? Do we still need
pkgs.haskellPackages.overrideforcrypton-connection? Shouldflake.lockbe updated? Anything else? Extra kudos if you can actually build it and confirm that it's in a working order.