Fix #288: allow mixing --local with and without paths when generating#438
Open
davidaf3 wants to merge 1 commit intondmitchell:masterfrom
Open
Fix #288: allow mixing --local with and without paths when generating#438davidaf3 wants to merge 1 commit intondmitchell:masterfrom
davidaf3 wants to merge 1 commit intondmitchell:masterfrom
Conversation
Collaborator
|
@davidaf3 could you please rebase so that the CI can be triggered? |
Author
|
Hi @Bodigrim, I have rebased the branch as requested |
Collaborator
|
Thanks for rebasing! Sorry for another delay, we discovered that hoogle.haskell.org was using a patched version of Hoogle and now waiting to upstream the patches in #468 before accumulating more changes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #288, allowing to mix the --local parameter with and without paths when generating a database, e.g.
hoogle generate --local --local=foo. This way you can include both your dependencies and your own code in a single database. Previously,--localwas ignored if another--local=foowas present.This is not as flexible as the design proposed in https://github.com/ndmitchell/hoogle/blob/master/src/Action/Generate.hs#L40, but it solves the issue for now.