fix(tests): handle missing sex_call in diplotype clustering tests for Amin1/Adir1#888
Open
adilraza99 wants to merge 1 commit intomalariagen:masterfrom
Open
fix(tests): handle missing sex_call in diplotype clustering tests for Amin1/Adir1#888adilraza99 wants to merge 1 commit intomalariagen:masterfrom
adilraza99 wants to merge 1 commit intomalariagen:masterfrom
Conversation
Adir1 and Amin1 datasets contain only "UKN" values for sex_call, so filters such as `sex_call == "F"` return zero samples and cause test failures. Apply the existing "no_sex_calls" pattern to exclude these datasets from sex_call-filtered tests while preserving behavior for others. No production code changes. Fixes malariagen#830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adir1 and Amin1 datasets contain only "UKN" values for
sex_callbecausesex chromosomes cannot be reliably identified from their fragmented assemblies.
Some diplotype clustering tests apply filters such as:
For these datasets, the filter returns zero samples, causing the clustering
workflow to fail.
What this PR does
This change applies the existing no_sex_calls test pattern (already used in
test_snp_data.py) to ensure datasets without sex call metadata are excludedfrom sex_call-filtered test cases.
Specifically:
• add Adir1 and Amin1 cases tagged with
no_sex_calls• exclude tagged datasets from tests that apply sex_call filters
• preserve existing behavior for datasets that support sex_call
Why this approach
Scope
Tests only. No production code changes.
Fixes #830