Fix hardcoded gene type and name attribute in test_plot_genes_with_ge…#875
Open
31puneet wants to merge 3 commits intomalariagen:masterfrom
Open
Fix hardcoded gene type and name attribute in test_plot_genes_with_ge…#87531puneet wants to merge 3 commits intomalariagen:masterfrom
31puneet wants to merge 3 commits intomalariagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #814
The test was querying
type == 'gene'and accessing["Name"]directly, both hardcoded for ag3. For af1 and adir1, the gene type isprotein_coding_geneand the name attribute isNote, so the query always returned empty — meaning genes were never actually found for af1/adir1 and the whole gene labels block was silently skipped.Changed:
"type == 'gene'"→f"type == '{api._gff_gene_type}'"["Name"]→[api._gff_gene_name_attribute]After the fix, genes are correctly found for af1 and adir1, and plot_genes() with gene labels is now actually tested for all datasets: