Skip to content

Update vtx_smartaudio.h #11286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skorya wants to merge 1 commit into from
+2 −2
Closed

Update vtx_smartaudio.h #11286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/io/vtx_smartaudio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
#define VTX_SMARTAUDIO_DEFAULT_POWER_COUNT 4
#define VTX_SMARTAUDIO_DEFAULT_POWER 1

#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 5000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 5999 //max freq in MHz
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
Comment on lines +40 to +41
Copy link
Contributor

@qodo-code-review qodo-code-review bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add compile-time validation to ensure the min/max frequency range is sane (min < max and within an expected absolute range), so misconfiguration is caught early. [Learned best practice, importance: 6]

Suggested change
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
#if (VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ >= VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ)
#error "VTX_SMARTAUDIO frequency range invalid: MIN_FREQUENCY_MHZ must be < MAX_FREQUENCY_MHZ"
#endif
#if (VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ < 1) || (VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ > 10000)
#error "VTX_SMARTAUDIO frequency range invalid: values out of expected MHz bounds"
#endif


// opmode flags, GET side
#define SA_MODE_GET_FREQ_BY_FREQ 1
Expand Down