Skip to content

Conversation

@skorya
Copy link

@skorya skorya commented Jan 25, 2026

PR Type

Bug fix


Description

  • Updates VTX SmartAudio frequency range constants

  • Expands minimum frequency from 5000 MHz to 1000 MHz

  • Expands maximum frequency from 5999 MHz to 8000 MHz

  • Broadens supported frequency band for SmartAudio devices


Diagram Walkthrough

flowchart LR
  A["VTX SmartAudio<br/>Frequency Constants"] -->|"MIN: 5000→1000 MHz"| B["Extended Lower<br/>Frequency Bound"]
  A -->|"MAX: 5999→8000 MHz"| C["Extended Upper<br/>Frequency Bound"]
  B --> D["Broader Supported<br/>Frequency Range"]
  C --> D
Loading

File Walkthrough

Relevant files
Bug fix
vtx_smartaudio.h
Expand SmartAudio frequency range constants                           

src/main/io/vtx_smartaudio.h

  • Changed VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ from 5000 to 1000 MHz
  • Changed VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ from 5999 to 8000 MHz
  • Expands the supported frequency range for SmartAudio VTX devices
+2/-2     

@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

Comment on lines +40 to +41
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add compile-time validation to ensure the min/max frequency range is sane (min < max and within an expected absolute range), so misconfiguration is caught early. [Learned best practice, importance: 6]

Suggested change
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
#define VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ 1000 //min freq in MHz
#define VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ 8000 //max freq in MHz
#if (VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ >= VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ)
#error "VTX_SMARTAUDIO frequency range invalid: MIN_FREQUENCY_MHZ must be < MAX_FREQUENCY_MHZ"
#endif
#if (VTX_SMARTAUDIO_MIN_FREQUENCY_MHZ < 1) || (VTX_SMARTAUDIO_MAX_FREQUENCY_MHZ > 10000)
#error "VTX_SMARTAUDIO frequency range invalid: values out of expected MHz bounds"
#endif

@skorya skorya closed this by deleting the head repository Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant