[LOW PRIORITY] Search box: expand downwards not sideways; truncate long workspace folder chips#513
Open
[LOW PRIORITY] Search box: expand downwards not sideways; truncate long workspace folder chips#513
Conversation
- searchbox gets deeper not wider and wraps text - long workspace folder chip names get truncated - add tooltip to truncated folder names to show full name
Contributor
|
@hoyla this is on playground here https://playground.pfi.gutools.co.uk/search - feel free to use playground any time by deploying project investigations::pfi-playground here https://riffraff.gutools.co.uk/deployment/request - it has deploy history on the right so you can check if anyone is likely to be using it |
Contributor
Author
Would the following have been correct to test that?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A new attempt at #474 (+1,189 −886 changes) that comes after the introduction of prettier. This one is less galling (+44, -5).
Attempt to fix the problem where long search terms cause the search box to extend offscreen.
What does this change?
Changes the behaviour of the Giant search box by increasing its depth for long queries rather than width. Secondly, very long workspace folder chip names - a common occurence - are truncated within the search box. A tooltip provides the full name.
How to test
How can we measure success?
If our searches don't lead to a search box that stretches off the right of the screen and renders it impossible to execute and see the results on the same screen.
Have we considered potential risks?
Well, it's LukeCode™ I'm afraid