Skip to content

LJH searchbox better chip experience#474

Closed
hoyla wants to merge 3 commits intomainfrom
ljh-searchbox-better-chip-experience
Closed

LJH searchbox better chip experience#474
hoyla wants to merge 3 commits intomainfrom
ljh-searchbox-better-chip-experience

Conversation

@hoyla
Copy link
Contributor

@hoyla hoyla commented Dec 29, 2025

What does this change?

  • Truncates very long "search in folder" chips because long folder names can break the UI (it becomes too wide for screens)
  • Adds a toolip showing the full name, so that can still be seen
  • Modifies the search box to grow vertically (multiple lines) rather than horizontally, also to address the problem with long search terms breaking the UI
  • Gets rid of the asterisk that was prebaked into search in folder searches, because it was confusing users.

How to test

NOT TESTED OR EVEN SEEN LOCALLY OR IN PLAYGROUND because I don't know how to make a local dev environment, and I'm loathe to attempt to deploy this to playground while everyone is away. So, apologies, can you perhaps try it locally or in playground, when you get to this.

Chip truncation test:

  1. Create deeply nested folders with long names (>75 characters)
  2. Verify chip label changes from "Workspace Folder" to "Folder" at 50 chars
  3. Verify truncation happens at 75 characters
  4. Hover over chip and confirm tooltip shows full path
  5. Test with various folder name lengths

Multi-line wrapping test

  1. Type very long search query (>100 characters)
  2. Verify text wraps to multiple lines
  3. Verify no horizontal expansion
  4. Add chips before and after long text
  5. Verify content below search box is pushed down, not overlapped
  6. Test with multiple chips + long text
  7. Test resizing browser window

Asterisk removal test

  1. Right-click on workspace folder
  2. Select "Search in folder"
  3. Verify no asterisk appears in search box
  4. Verify cursor is ready for typing
  5. Press Enter without typing - verify search still works
  6. Type a search term and verify filtering works

How can we measure success?

Fewer confused users. Or at least, we will be less responsible for their confusion.

Have we considered potential risks?

Yeah, Luke thinks vibe coding is a thing

@hoyla hoyla requested a review from a team as a code owner December 29, 2025 11:53
@hoyla hoyla changed the title LJH earchbox better chip experience LJH searchbox better chip experience Dec 29, 2025
@hoyla hoyla added feature Departmental tracking: work on a new feature ux/ui search labels Dec 29, 2025
@hoyla hoyla linked an issue Dec 29, 2025 that may be closed by this pull request
@hoyla hoyla added this to the 2025 Q4 milestone Dec 29, 2025
@hoyla
Copy link
Contributor Author

hoyla commented Jan 5, 2026

Because my incorrect Prettification has resulted in hundreds of lines of changes, we're parking this pending @philmcmahon and @twrichards proposals about implementing Prettier and eslint for Giant. There's nothing remotely urgent about this PR so it can wait until the linting is in place and then we can update these PRs to comply.

@hoyla hoyla self-assigned this Jan 20, 2026
@hoyla
Copy link
Contributor Author

hoyla commented Jan 20, 2026

Back with me to redo from scratch following lint rules change

@hoyla
Copy link
Contributor Author

hoyla commented Jan 23, 2026

Replaced by #513

@hoyla hoyla closed this Jan 23, 2026
@hoyla hoyla deleted the ljh-searchbox-better-chip-experience branch January 23, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature search ux/ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant