Skip to content

fix: revert change to codemod now that Entity.knexLoader is supported again via subclass#443

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-13-fix_revert_change_to_codemod_now_that_entity.knexloader_is_supported_again_via_subclass
Feb 16, 2026
Merged

fix: revert change to codemod now that Entity.knexLoader is supported again via subclass#443
wschurman merged 1 commit intomainfrom
wschurman/02-13-fix_revert_change_to_codemod_now_that_entity.knexloader_is_supported_again_via_subclass

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 13, 2026

Why

Part 3 of the refactor from #441.

This reverts the codemod back to use the BlahEntity.knexLoader(vc) syntax.

How

git revert

Test Plan

Run the tests in codemod.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (40b409f) to head (a0b5716).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #443   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines        15944     15944           
  Branches       862       849   -13     
=========================================
  Hits         15944     15944           
Flag Coverage Δ
integration 22.71% <ø> (ø)
unittest 95.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman mentioned this pull request Feb 15, 2026
@wschurman wschurman force-pushed the wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods branch from 35b6ed0 to 701c768 Compare February 16, 2026 00:06
@wschurman wschurman force-pushed the wschurman/02-13-fix_revert_change_to_codemod_now_that_entity.knexloader_is_supported_again_via_subclass branch from c2f1892 to 40502d6 Compare February 16, 2026 00:06
Copy link
Member Author

wschurman commented Feb 16, 2026

Merge activity

  • Feb 16, 8:58 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 16, 9:19 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 16, 9:22 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods to graphite-base/443 February 16, 2026 21:15
@wschurman wschurman changed the base branch from graphite-base/443 to main February 16, 2026 21:18
@wschurman wschurman force-pushed the wschurman/02-13-fix_revert_change_to_codemod_now_that_entity.knexloader_is_supported_again_via_subclass branch from 40502d6 to a0b5716 Compare February 16, 2026 21:19
@wschurman wschurman merged commit ed6b2e0 into main Feb 16, 2026
5 checks passed
@wschurman wschurman deleted the wschurman/02-13-fix_revert_change_to_codemod_now_that_entity.knexloader_is_supported_again_via_subclass branch February 16, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments