Skip to content

feat: add PostgresEntity/ReadonlyPostgresEntity classes that expose knexLoader methods#442

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods
Feb 16, 2026
Merged

feat: add PostgresEntity/ReadonlyPostgresEntity classes that expose knexLoader methods#442
wschurman merged 1 commit intomainfrom
wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 13, 2026

Why

This is part 2 of the refactor described in #441.

It adds subclasses of Entity and ReadonlyEntity that supply the static knexLoader methods to keep the ergonomics of the extension but without the monkey-patching.

How

Add subclasses, add test.

Test Plan

Run test.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (51d632d) to head (31ca8c0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #442    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          107       109     +2     
  Lines        15713     15944   +231     
  Branches       860       862     +2     
==========================================
+ Hits         15713     15944   +231     
Flag Coverage Δ
integration 22.71% <0.00%> (-0.34%) ⬇️
unittest 95.09% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman requested review from ide and quinlanj February 14, 2026 18:53
@wschurman wschurman marked this pull request as ready for review February 14, 2026 18:53
@wschurman wschurman mentioned this pull request Feb 15, 2026
@wschurman wschurman force-pushed the wschurman/02-13-fix_refactor_install_method_to_instead_be_free_functions branch from bced9f8 to 429ae05 Compare February 16, 2026 00:06
@wschurman wschurman force-pushed the wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods branch from 35b6ed0 to 701c768 Compare February 16, 2026 00:06
Copy link
Member Author

wschurman commented Feb 16, 2026

Merge activity

  • Feb 16, 8:58 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 16, 9:15 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 16, 9:18 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-13-fix_refactor_install_method_to_instead_be_free_functions to graphite-base/442 February 16, 2026 21:11
@wschurman wschurman changed the base branch from graphite-base/442 to main February 16, 2026 21:14
@wschurman wschurman force-pushed the wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods branch from 701c768 to 31ca8c0 Compare February 16, 2026 21:15
@wschurman wschurman merged commit 40b409f into main Feb 16, 2026
5 checks passed
@wschurman wschurman deleted the wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods branch February 16, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments