Test on Windows: Make features in section 2 pass

.github/workflows/test.yml

@@ -47,17 +47,8 @@ jobs:
         # Cucumber 9  | Ruby 2.7
         # Cucumber 10 | Ruby 3.1
         #
-        ruby: ["3.1", "jruby-9.4", "3.2", "3.3", "3.4", "jruby-10.0", "4.0"]
+        ruby: ["3.3"]
         appraisal: [cucumber_10]
-        include:
-          - ruby: "3.0"
-            appraisal: cucumber_8
-          - ruby: "3.0"
-            appraisal: cucumber_9
-          - ruby: "3.1"
-            appraisal: cucumber_9
-          - ruby: "4.0"
-            appraisal: rspec_4
 
     env:
       BUNDLE_GEMFILE: gemfiles/${{ matrix.appraisal }}.gemfile
@@ -80,7 +71,7 @@ jobs:
       matrix:
         # This will automatically pick the latest supported version of Cucumber
         # for each Ruby version
-        ruby: ["3.0", "3.1", "3.2", "3.3", "3.4", "4.0"]
+        ruby: ["3.3"]
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
@@ -101,7 +92,7 @@ jobs:
       matrix:
         # This will automatically pick the latest supported version of Cucumber
         # for each Ruby version
-        ruby: ["3.0", "3.1", "3.2", "3.3", "3.4", "4.0"]
+        ruby: ["3.3"]
     runs-on: windows-latest
     steps:
       - name: git config autocrlf
@@ -113,12 +104,14 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler: latest
           bundler-cache: true
-      - name: Run specs
-        run: bundle exec rake spec
-      - name: Run cukes (1)
-        run: bundle exec cucumber features/01_getting_started_with_aruba/
+      # - name: Run specs
+      #   run: bundle exec rake spec
+      # - name: Run cukes (1)
+      #   run: bundle exec cucumber features/01_getting_started_with_aruba/
       # - name: Run cukes (2)
       #   run: bundle exec cucumber features/02_configure_aruba/
+      - name: Run cukes - focus!
+        run: bundle exec cucumber features/02_configure_aruba/basics.feature
       # - name: Run cukes (3)
       #   run: bundle exec cucumber features/03_testing_frameworks/
       # - name: Run cukes (4)

features/02_configure_aruba/activate_announcer_on_command_failure.feature

@@ -24,7 +24,7 @@ Feature: Configure announcer activation on command failure
     Given I use the fixture "cli-app"
 
   Scenario: Default value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       puts %(The default value is "#{config.activate_announcer_on_command_failure.inspect}")
@@ -37,7 +37,7 @@ Feature: Configure announcer activation on command failure
     """
 
   Scenario: Modify value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       config.activate_announcer_on_command_failure = [:stderr, :stdout]

features/02_configure_aruba/basics.feature

@@ -14,17 +14,17 @@ Feature: Usage of configuration
   Background:
     Given I use a fixture named "cli-app"
     And an executable named "bin/aruba-test-cli" with:
-    """bash
-    #!/bin/bash
-    trap "exit 128" SIGTERM SIGINT
-    sleep $*
+    """ruby
+    #!/usr/bin/env ruby
+    sleep ARGV[0].to_f
     """
 
+  @announce-output
   Scenario: Setting default values for option for RSpec
     Given a file named "spec/support/aruba_config.rb" with:
     """ruby
     Aruba.configure do |config|
-      config.exit_timeout = 0.7
+      config.exit_timeout = 1.0
     end
     """
     And a file named "spec/usage_configuration_spec.rb" with:
@@ -34,18 +34,19 @@ Feature: Usage of configuration
     RSpec.describe 'Run command', :type => :aruba do
       context 'when fast command' do
         before { run_command('aruba-test-cli 0') }
-        it { expect(last_command_started).to be_successfully_executed }
+        it { expect(last_command_started).to have_finished_in_time }
       end
 
       context 'when slow command' do
         before { run_command('aruba-test-cli 1') }
-        it { expect(last_command_started).not_to be_successfully_executed }
+        it { expect(last_command_started).not_to have_finished_in_time }
       end
     end
     """
     When I run `rspec`
     Then the specs should all pass
 
+  @announce-output
   Scenario: Setting option during runtime for RSpec
 
     Maybe there are some long running tests, which need longer. You may not
@@ -55,7 +56,7 @@ Feature: Usage of configuration
     Given a file named "spec/support/aruba_config.rb" with:
     """ruby
     Aruba.configure do |config|
-      config.exit_timeout = 0.5
+      config.exit_timeout = 1.0
     end
     """
     And a file named "spec/support/hooks.rb" with:
@@ -64,7 +65,7 @@ Feature: Usage of configuration
       config.before :each do |example|
         next unless example.metadata.key? :slow_command
 
-        aruba.config.exit_timeout = 1.5
+        aruba.config.exit_timeout = 2.5
       end
     end
     """
@@ -75,77 +76,99 @@ Feature: Usage of configuration
     RSpec.describe 'Run command', :type => :aruba do
       context 'when fast command' do
         before { run_command('aruba-test-cli 0') }
-        it { expect(last_command_started).to be_successfully_executed }
+        it { expect(last_command_started).to have_finished_in_time }
       end
 
       context 'when slow command and this is known by the developer', :slow_command => true do
-        before { run_command('aruba-test-cli 1') }
-        it { expect(last_command_started).to be_successfully_executed }
+        before { run_command('aruba-test-cli 1.1') }
+        it { expect(last_command_started).to have_finished_in_time }
       end
 
       context 'when slow command, but this might be a failure' do
-        before { run_command('aruba-test-cli 1') }
-        it { expect(last_command_started).not_to be_successfully_executed }
+        before { run_command('aruba-test-cli 1.1') }
+        it { expect(last_command_started).not_to have_finished_in_time }
       end
     end
     """
     When I run `rspec`
     Then the specs should all pass
 
+  @announce-output
   Scenario: Setting default values for option for Cucumber
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
-      config.exit_timeout = 0.5
+      config.exit_timeout = 1.0
+    end
+    """
+    And a file named "features/step_definitions/timeout_steps.rb" with:
+    """ruby
+    Then 'the command should finish in time' do
+      expect(last_command_started).to have_finished_in_time
+    end
+
+    Then 'the command should time out' do
+      expect(last_command_started).to run_too_long
     end
     """
     And a file named "features/run.feature" with:
     """
     Feature: Run it
       Scenario: Fast command
         When I run `aruba-test-cli 0`
-        Then the exit status should be 0
+        Then the command should finish in time
 
       Scenario: Slow command
         When I run `aruba-test-cli 1.0`
-        Then the exit status should be 128
+        Then the command should time out
     """
     When I run `cucumber`
     Then the features should all pass
 
+  @announce-output
   Scenario: Setting option during runtime for Cucumber
 
     Maybe there are some long running tests, which need longer. You may not
     want to set the default timeout for all commands to the maximum value only
     to prevent those commands from failing.
 
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
-      config.exit_timeout = 0.2
+      config.exit_timeout = 0.5
     end
     """
     And a file named "features/support/hooks.rb" with:
     """ruby
     Before '@slow-command' do
-      aruba.config.exit_timeout = 1.5
+      aruba.config.exit_timeout = 2.5
+    end
+    """
+    And a file named "features/step_definitions/timeout_steps.rb" with:
+    """ruby
+    Then 'the command should finish in time' do
+      expect(last_command_started).to have_finished_in_time
+    end
+
+    Then 'the command should time out' do
+      expect(last_command_started).to run_too_long
     end
     """
     And a file named "features/usage_configuration.feature" with:
     """
     Feature: Run it
       Scenario: Fast command
         When I run `aruba-test-cli 0`
-        Then the exit status should be 0
+        Then the command should finish in time
 
       @slow-command
-      Scenario: Slow command known by the developer
-        When I run `aruba-test-cli 0.5`
-        Then the exit status should be 0
+      Scenario: Slow command finishes when given more time
+        When I run `aruba-test-cli 1.1`
+        Then the command should finish in time
 
-      Scenario: Slow command which might be a failure
-        When I run `aruba-test-cli 0.5`
-        Then the exit status should be 128
+      Scenario: Slow command fails
+        When I run `aruba-test-cli 1.1`
+        Then the command should time out
     """
     When I run `cucumber`
     Then the features should all pass

features/02_configure_aruba/console_history_file.feature

@@ -8,7 +8,7 @@ Feature: Configure the aruba console history file
     Given I use the fixture "cli-app"
 
   Scenario: Default value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """
     Aruba.configure do |config|
       puts %(The default value is "#{config.console_history_file}")
@@ -21,7 +21,7 @@ Feature: Configure the aruba console history file
     """
 
   Scenario: Set some value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """
     Aruba.configure do |config|
       config.console_history_file = '~/.config/aruba/history.txt'

features/02_configure_aruba/exit_timeout.feature

@@ -4,17 +4,26 @@ Feature: Configure timeout for command execution
   I want to configure the timeout when executing a command
   In order to support some longer running commands
 
+  Note that on Windows, you must check for timeouts explicitly and cannot rely
+  on a nonzero exit status: Killing the process from Ruby when the timeout
+  occurs will set the exit status to 0.
+
   Background:
     Given I use the fixture "cli-app"
     And an executable named "bin/aruba-test-cli" with:
-    """bash
-    #!/bin/bash
-    trap "exit 128" SIGTERM SIGINT
-    sleep $*
+    """ruby
+    #!/usr/bin/env ruby
+    sleep ARGV[0].to_f
+    """
+    And a file named "features/step_definitions/timeout_steps.rb" with:
+    """ruby
+    Then 'the command should finish in time' do
+      expect(last_command_started).to have_finished_in_time
+    end
     """
 
   Scenario: Default value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       puts %(The default value is "#{config.exit_timeout}")
@@ -27,7 +36,7 @@ Feature: Configure timeout for command execution
     """
 
   Scenario: Modify value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       config.exit_timeout = 1.0
@@ -37,13 +46,13 @@ Feature: Configure timeout for command execution
     """
     Feature: Run it
       Scenario: Fast command
-        When I run `aruba-test-cli 0.5`
-        Then the exit status should be 0
+        When I run `aruba-test-cli 0.1`
+        Then the command should finish in time
     """
     Then I successfully run `cucumber`
 
   Scenario: Fails if takes longer
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       config.exit_timeout = 0.5
@@ -54,7 +63,7 @@ Feature: Configure timeout for command execution
     Feature: Run it
       Scenario: Fast command
         When I run `aruba-test-cli 2.5`
-        Then the exit status should be 0
+        Then the command should finish in time
     """
     Then I run `cucumber`
     And the exit status should be 1

features/02_configure_aruba/fixtures_directories.feature

@@ -8,7 +8,7 @@ Feature: Configure directory where to look for fixtures
     Given I use the fixture "cli-app"
 
   Scenario: Default value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       puts %(The default value is "%w(#{config.fixtures_directories.join(" ")})")
@@ -21,7 +21,7 @@ Feature: Configure directory where to look for fixtures
     """
 
   Scenario: Modify value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       config.fixtures_directories = %w(spec/fixtures)

features/02_configure_aruba/fixtures_path_prefix.feature

@@ -8,7 +8,7 @@ Feature: Use fixtures path prefix of aruba
     Given I use the fixture "cli-app"
 
   Scenario: Default value
-    Given a file named "features/support/aruba_config.rb" with:
+    Given a file named "features/support/aruba.rb" with:
     """ruby
     Aruba.configure do |config|
       puts "The prefix is \"#{config.fixtures_path_prefix}\"."