Open
Conversation
Contributor
Author
|
I'm beginning to suspect the |
mvz
force-pushed
the
run-cucumber-features-section-2-on-windows
branch
2 times, most recently
from
4e0743d to
20b1ac0
Compare
Contributor
Author
|
The |
mvz
force-pushed
the
run-cucumber-features-section-2-on-windows
branch
from
4bec7ab to
79bdbe8
Compare
This change ensures no errors were reported, and that both checks are performed before reporting any failures.
There may be a load order issue when loading aruba and its config in separate Cucumber support files whose name does not start with 'env'. This change makes the 'env.rb' file load aruba directly, so Aruba should definitely be available when configuring it.
mvz
force-pushed
the
run-cucumber-features-section-2-on-windows
branch
from
9c83dcc to
87e0d02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes GitHub Actions additionally run the Cucumber scenarios in section 02 (configure Aruba) on Windows, and makes them pass.
Details
This cherry-picks commits from #894 (and originally from other pull requests) that affect scenarios from section 02, and adds one new commit for a remaining feature from that section. All changes are changes to the scenario's, not Aruba's code.
Motivation and Context
Another small step toward fully testing on Windows.
How Has This Been Tested?
I ran the cukes locally. Proof on Windows must come from CI.
Types of changes