Add missing View and TestSuite property renames for CakePHP 6.0 #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
force-pushed
the
add-view-testsuite-property-renames
branch
from
a6d4b6d to
cb75883
Compare
dereuromark
force-pushed
the
add-view-testsuite-property-renames
branch
from
cb75883 to
895c9c8
Compare
Adds property rename rules for: - View package: View, ViewBuilder, ViewBlock, Cell, Helper, FormHelper, HtmlHelper, TextHelper, UrlHelper, StringTemplate, WidgetLocator, various widgets, form contexts - TestSuite package: IntegrationTestTrait, TestCase, StringCompareTrait, EventFired constraints - Validation: ValidatorAwareTrait - Log: SyslogLog._levelMap These properties follow the PSR naming convention change from underscore-prefixed to non-prefixed names.
LordSimal
force-pushed
the
add-view-testsuite-property-renames
branch
from
895c9c8 to
2dd50de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds property rename rules for packages that were missing from the CakePHP 6.0 rector configuration:
These properties follow the PSR naming convention change from underscore-prefixed to non-prefixed names (e.g.,
$_helpers→$helpers).This ensures user code that extends these classes will be automatically updated when running the upgrade tool.
Note:
│ I18n*::$_toStringFormat │ Conflicts with Chronos parent │ Left unchanged