Cleanup for new major (required by Cake6) #497
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove $range parameter from toQuarter() (deprecated in 3.3.0) - Update tests to remove deprecated usage - Remove outdated PHPStan ignore for createFromTimestamp()
dereuromark
changed the title
Allow subclasses to use IntlDateFormatter constants by widening the $toStringFormat property type from string to array|string|int. This enables CakePHP I18n classes to rename $_toStringFormat to $toStringFormat without type conflicts.
LordSimal
reviewed
Feb 6, 2026
| * @var array|string|int | ||
| */ | ||
| protected static string $toStringFormat = self::DEFAULT_TO_STRING_FORMAT; | ||
| protected static array|string|int $toStringFormat = self::DEFAULT_TO_STRING_FORMAT; |
Contributor
There was a problem hiding this comment.
Isn't this considered a breaking change for non cakephp apps using this?
Member
Author
There was a problem hiding this comment.
Yes, thats BC breaking why this is targeting 4x, see milestone and PR descr.
Same as deprecation removal etc is.
But no, not for Cake Apps, explained above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major release cleanup for Chronos 4.0 / CakePHP 6.0 compatibility:
$rangeparameter fromtoQuarter()which was deprecated in 3.3.0toQuarterRange()for quarter range functionality$toStringFormatproperty type fromstringtoarray|string|int$_toStringFormatto$toStringFormatwithout type conflictsDateTimeImmutable::createFromTimestamp()(now available in PHP 8.4)Refs: cakephp/upgrade#386
Note:
The type widening is backwards compatible because CakePHP 5 I18n classes use their own $_toStringFormat property and override all related methods - they don't touch Chronos's property at all. The widening just enables
CakePHP 6 to do the PSR naming cleanup.