Skip to content

docs(query-payments): rewrite with practical implementation focus and remove AI warning#66

Open
aimensahnoun wants to merge 1 commit into03-02-docs_api-features_fix_query-requests_openapi_endpoint_links_and_reconciliation_mapping_update_api-features_query-requests.mdx_to_use_the_correct_openapi_deep_links_for_request_status_and_wallet-level_reconciliation._-_replaced_nfrom
03-02-docs_api-features_rebuild_reconciliation_query_pages_with_correct_v2_endpoints_refactor_query-requests_and_query-payments_docs_to_align_with_actual_api_behavior_and_fix_endpoint_linking_issues_in_openapi_references._-_removed_ai
Open

docs(query-payments): rewrite with practical implementation focus and remove AI warning#66
aimensahnoun wants to merge 1 commit into03-02-docs_api-features_fix_query-requests_openapi_endpoint_links_and_reconciliation_mapping_update_api-features_query-requests.mdx_to_use_the_correct_openapi_deep_links_for_request_status_and_wallet-level_reconciliation._-_replaced_nfrom
03-02-docs_api-features_rebuild_reconciliation_query_pages_with_correct_v2_endpoints_refactor_query-requests_and_query-payments_docs_to_align_with_actual_api_behavior_and_fix_endpoint_linking_issues_in_openapi_references._-_removed_ai

Conversation

@aimensahnoun
Copy link
Member

@aimensahnoun aimensahnoun commented Mar 2, 2026

TL;DR

Rewrote the Query Payments documentation page to provide clearer, more actionable guidance with step-by-step instructions and practical implementation details.

What changed?

  • Removed AI-generated content warning and disclaimer
  • Replaced mermaid diagram with structured Steps component explaining the query process
  • Added comprehensive filter documentation organized by category (Identity/Transaction, Type/Currency, Time/Pagination)
  • Included practical implementation notes about search semantics, batch transactions, and idempotency considerations
  • Added related pages section linking to Query Requests, Payment Detection, and Webhooks & Events
  • Restructured content to focus on the core GET /v2/payments endpoint with direct API reference links

How to test?

  • Review the documentation page to ensure all filter parameters and their usage are clearly explained
  • Verify that the step-by-step process accurately reflects the API behavior
  • Test that internal links to related pages work correctly
  • Confirm the API reference link points to the correct OpenAPI documentation

Why make this change?

The original documentation was AI-generated with a disclaimer about potential inaccuracies. This rewrite provides developers with more reliable, structured guidance that focuses on practical implementation patterns and real-world usage scenarios for payment querying and reconciliation workflows.

…2 endpoints

Refactor `query-requests` and `query-payments` docs to align with actual API behavior and fix endpoint linking issues in OpenAPI references.
- removed AI-generated warning banners from both pages
- replaced outdated/broken API reference paths with canonical OpenAPI links
- corrected endpoint linking strategy for request status and payment search routes
- aligned `query-requests` to request-level reconciliation flow using:
  - GET /v2/request/{requestId}
  - GET /v2/payments (wallet-level reconciliation context)
- replaced related-page bullet links with CardGroup components for consistency
- rebuilt `query-payments` as endpoint-driven documentation for:
  - GET /v2/payments
  - required search parameter behavior
  - filter groups (identity/tx, type/currency, date/pagination)
  - response pagination fields (`total`, `limit`, `offset`, `hasMore`)
  - practical reconciliation notes (AND semantics, batch tx behavior, idempotency)
- removed legacy-domain dependencies and invalid internal endpoint links
- kept structure consistent with other migrated API Features pages
Copy link
Member Author

aimensahnoun commented Mar 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aimensahnoun aimensahnoun self-assigned this Mar 2, 2026
@aimensahnoun aimensahnoun changed the title docs(api-features): rebuild reconciliation query pages with correct v2 endpoints Refactor query-requests and query-payments docs to align with actual API behavior and fix endpoint linking issues in OpenAPI references. - removed AI-generated warning ba docs(query-payments): rewrite with practical implementation focus and remove AI warning Mar 2, 2026
@aimensahnoun aimensahnoun marked this pull request as ready for review March 2, 2026 12:12
@greptile-apps
Copy link

greptile-apps bot commented Mar 2, 2026

Greptile Summary

This PR successfully removes AI-generated content warnings and rewrites the Query Payments documentation with clearer, more actionable implementation guidance. The documentation now uses structured Steps components, organizes filter parameters by category (Identity/Transaction, Type/Currency, Time/Pagination), and includes practical implementation notes about search semantics, batch transactions, and idempotency.

Key improvements:

  • Replaced generic mermaid diagram with step-by-step implementation guidance
  • Documented specific filter parameters with clear usage patterns
  • Added practical notes about AND semantics and batch transaction behavior
  • Included proper internal links to related pages (Query Requests, Payment Detection, Webhooks & Events)
  • Updated API reference links to point to canonical OpenAPI documentation

Issues found:

  • Frontmatter description references /payments instead of /v2/payments (inconsistent with content)
  • Payment type value direct should be verified against actual API schema

Confidence Score: 4/5

  • This documentation PR is safe to merge with minor corrections needed for endpoint path consistency
  • Score reflects high-quality documentation improvements with clear structure and practical guidance, but includes a minor endpoint path inconsistency in the frontmatter and an unverified API parameter value that should be confirmed
  • No files require special attention beyond addressing the two comments on api-features/query-payments.mdx

Important Files Changed

Filename Overview
api-features/query-payments.mdx Rewrote documentation with practical guidance, removed AI warning, improved structure - minor inconsistency in frontmatter endpoint path

Last reviewed commit: 821e504

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@@ -3,88 +3,114 @@ title: "Query Payments"
description: "Advanced payment search and filtering with the GET /payments endpoint"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description should reference /v2/payments not /payments to match content

Suggested change
description: "Advanced payment search and filtering with the GET /payments endpoint"
description: "Advanced payment search and filtering with the GET /v2/payments endpoint"

- **Transaction Hash:** Specific transaction lookup
- **Request ID:** Payments for specific requests
### Type and Currency Filters
- `type`: `direct`, `conversion`, `crosschain`, `recurring`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify direct is the correct API type value - payment-types-overview documents "Native & ERC20" instead - check actual API schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant