Build cleanup: reduce warnings, add unit tests, modernize project

CSharpExt.UnitTests/PercentTests.cs

@@ -147,7 +147,10 @@ public void LessThanCompare()
         c.ShouldBeTrue();
         c = p2 < p1;
         c.ShouldBeFalse();
+
+#pragma warning disable CS1718 // Intentional self-comparison to test operators
         c = p1 < p1;
+#pragma warning restore CS1718
         c.ShouldBeFalse();
     }
 
@@ -160,7 +163,9 @@ public void LessThanOrEqualCompare()
         c.ShouldBeTrue();
         c = p2 <= p1;
         c.ShouldBeFalse();
+#pragma warning disable CS1718 // Intentional self-comparison to test operators
         c = p1 <= p1;
+#pragma warning restore CS1718
         c.ShouldBeTrue();
     }
 
@@ -173,7 +178,9 @@ public void GreaterThanOrEqualCompare()
         c.ShouldBeFalse();
         c = p2 >= p1;
         c.ShouldBeTrue();
+#pragma warning disable CS1718 // Intentional self-comparison to test operators
         c = p1 >= p1;
+#pragma warning restore CS1718
         c.ShouldBeTrue();
     }
 
@@ -186,7 +193,9 @@ public void GreaterThanCompare()
         c.ShouldBeFalse();
         c = p2 > p1;
         c.ShouldBeTrue();
+#pragma warning disable CS1718 // Intentional self-comparison to test operators
         c = p1 > p1;
+#pragma warning restore CS1718
         c.ShouldBeFalse();
     }
 }

Directory.Packages.props

@@ -66,7 +66,7 @@
   <ItemGroup Condition=" $(TargetFramework.StartsWith('netstandard2.0')) ">
     <PackageVersion Update="System.Buffers" Version="4.5.1" />
     <PackageVersion Update="System.Memory" Version="4.5.5" />
-    <PackageVersion Include="System.Threading.Tasks" Version="4.3.0" />
+
     <PackageVersion Update="Microsoft.Bcl.HashCode" Version="1.1.1" />
   </ItemGroup>
 </Project>

Noggog.CSharpExt/Noggog.CSharpExt.csproj

@@ -33,10 +33,6 @@
     <PackageReference Include="System.Linq.Async" />
   </ItemGroup>
 
-  <ItemGroup Condition=" $(TargetFramework.StartsWith('netstandard2.0')) ">
-    <PackageReference Include="System.Threading.Tasks" />
-  </ItemGroup>
-
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
     <PackageReference Include="Microsoft.Bcl.HashCode" />
     <PackageReference Include="System.Buffers" />

Noggog.CSharpExt/WorkEngine/WorkConsumer.cs

@@ -152,7 +152,7 @@ public void Start()
             .Select(x => x ?? 0)
             .Select(x => x == 0 ? Environment.ProcessorCount : x)
             .DistinctUntilChanged()
-            .Subscribe(AddNewThreadsIfNeeded)
+            .SubscribeAsyncConcat(AddNewThreadsIfNeeded)
             .DisposeWithComposite(_disposable);
     }
 

Noggog.Testing/Extensions/ShouldlyExt.cs

@@ -44,7 +44,7 @@ internal static bool RoughlyEqual<TLhs>(TLhs actual, object? expected)
             TLhs? convertedExpected = (TLhs?)ConvertWithImplicitOperator(expected, actual.GetType());
             if (object.Equals(actual, convertedExpected)) return true;
         }
-        catch (Exception e)
+        catch (Exception)
         {
         }
 
@@ -53,7 +53,7 @@ internal static bool RoughlyEqual<TLhs>(TLhs actual, object? expected)
             TLhs? convertedExpected = (TLhs?)Convert.ChangeType(expected, actual.GetType());
             if (object.Equals(actual, convertedExpected)) return true;
         }
-        catch (Exception e)
+        catch (Exception)
         {
         }
 
@@ -64,7 +64,7 @@ internal static bool RoughlyEqual<TLhs>(TLhs actual, object? expected)
                 var convertedExpected = convertibleExpected.ToType(actual.GetType(), null);
                 if (object.Equals(actual, convertedExpected)) return true;
             }
-            catch (Exception e)
+            catch (Exception)
             {
             }
         }

Noggog.Testing/FileSystem/MockFileSystemWatcher.cs

@@ -84,7 +84,9 @@ public IWaitForChangedResult WaitForChanged(WatcherChangeTypes changeType, TimeS
     public event FileSystemEventHandler? Changed;
     public event FileSystemEventHandler? Created;
     public event FileSystemEventHandler? Deleted;
+#pragma warning disable CS0067 // Required by IFileSystemWatcher interface
     public event ErrorEventHandler? Error;
+#pragma warning restore CS0067
     public event RenamedEventHandler? Renamed;
 
     public MockFileSystemWatcher(IFileSystem fileSystem)

Noggog.WPF/Extensions/DependencyObjectExt.cs

@@ -16,7 +16,7 @@ public static bool TryGetAncestor<TObj>(this DependencyObject obj, [MaybeNullWhe
             {
                 item = VisualTreeHelper.GetParent(item);
             }
-            catch (InvalidOperationException e)
+            catch (InvalidOperationException)
             {
                 break;
             }