Build cleanup: reduce warnings, add unit tests, modernize project#21
Merged
Build cleanup: reduce warnings, add unit tests, modernize project#21
Conversation
- Remove unnecessary System.Threading.Tasks package reference (NU1510) - Remove unused catch exception variables (CS0168) - Suppress intentional self-comparison warnings in operator tests (CS1718) - Suppress interface-required but unused Error event in mock (CS0067) - Replace obsolete Subscribe call with SubscribeAsyncConcat (CS0618)
Noggog
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A collection of build hygiene improvements that reduce compiler warnings from 126 to 94 and modernize the project infrastructure.
Changes
Build warning reduction (126 → 94)
System.Threading.Taskspackage reference that NuGet flagged as redundant (NU1510)ShouldlyExt.csandDependencyObjectExt.cs(CS0168)PercentTests.csoperator tests (CS1718)Errorevent inMockFileSystemWatcher(CS0067)Subscribecall withSubscribeAsyncConcatinWorkConsumer(CS0618)Unit tests
BinaryReadStreamunit tests covering read operations, position tracking, edge cases, and error handlingProject infrastructure
.slnto.slnxformat