Conversation
Member
Author
|
dont merge yet |
g4titanx
force-pushed
the
fix/runtime_section_detection
branch
from
7cde3da to
0d44544
Compare
Member
|
@ozwaldorf minor review, basically just this commit |
Member
Author
|
i cant review because i opened the pr. @ozwaldorf |
ozwaldorf
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the fragile heuristic-based runtime section detection with a simple and deterministic approach. The old code tried to guess where runtime bytecode starts by pattern-matching on CODECOPY+RETURN sequences, which failed unpredictably across different compiler versions and optimization levels. It required multiple fallback passes and would literally estimate values when it couldn't find them.
The new implementation takes the actual runtime bytecode as an optional parameter and does a direct substring search using a sliding window. When you provide both deployment and runtime bytecode, it finds the exact offset by matching the first 20 bytes of runtime within deployment. This is fast, reliable, and works regardless of how the bytecode was compiled.