Skip to content

refactor(core): refactor strip module#109

Draft
g4titanx wants to merge 4 commits intomasterfrom
strip/parser
Draft

refactor(core): refactor strip module#109
g4titanx wants to merge 4 commits intomasterfrom
strip/parser

Conversation

@g4titanx
Copy link
Member

@g4titanx g4titanx commented Nov 3, 2025

closes #108

Copy link
Member

@EmperorOrokuSaki EmperorOrokuSaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary when we are just accepting the runtime and the deployment bytecodes in the cli?

see #90

@EmperorOrokuSaki EmperorOrokuSaki added Hard Requires more technicality Unimportant Nice to have but not urgent labels Nov 20, 2025
@g4titanx
Copy link
Member Author

why is this necessary when we are just accepting the runtime and the deployment bytecodes in the cli?

see #90

we are accepting the deployment bytecode. doesnt mean we cant also accept the runtime bytecode, it's been designed to be able to handle both in the latest, in fact this has been improved #105

@g4titanx
Copy link
Member Author

this pr would be rebased after the review on #105 is done and then we can continue breaking the module down into smaller modules for more clarity and manageability

@EmperorOrokuSaki
Copy link
Member

why is this necessary when we are just accepting the runtime and the deployment bytecodes in the cli?
see #90

we are accepting the deployment bytecode. doesnt mean we cant also accept the runtime bytecode, it's been designed to be able to handle both in the latest, in fact this has been improved #105

We only need to detect the runtime like this, when we don't have it given to us in the cli. since we are using azoth for mirage and have other high priority tasks to attend to, and we are always supplying the runtime, we should deprioritize this.

i'm going to park this for now. let's clean up #90 and have it merged

@g4titanx
Copy link
Member Author

okay then i'd add to my task for the day

@ozwaldorf ozwaldorf marked this pull request as draft November 24, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hard Requires more technicality Unimportant Nice to have but not urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(core): build a parser for stripping logic

2 participants