Skip to content

feat: add merkl yield claim transaction type to TransactionType enum #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatrykLucka wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

feat: add merkl yield claim transaction type to TransactionType enum #7723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef72a9
feat: add merkl yield claim transaction type to TransactionType enum
PatrykLucka Jan 26, 2026
b4380e5
chore: update changelog
PatrykLucka Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/transaction-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add support for `transactionHistoryLimit` feature flag to configure the maximum number of transactions stored in state ([#7648](https://github.com/MetaMask/core/pull/7648))
- Defaults to 40 if not provided.
- Add optional `callTraceErrors` to `simulationData` ([#7641](https://github.com/MetaMask/core/pull/7641))
- Add `merklYieldClaim` transaction type ([#7723](https://github.com/MetaMask/core/pull/7723))

### Changed

Expand Down
5 changes: 5 additions & 0 deletions packages/transaction-controller/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,11 @@ export enum TransactionType {
*/
lendingWithdraw = 'lendingWithdraw',

/**
* A transaction that claims yield from a Merkl Yield contract.
*/
merklYieldClaim = 'merklYieldClaim',
Copy link
Member

@matthewwalsh0 matthewwalsh0 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary hold while we discuss use case.

Copy link
Contributor

@Matt561 Matt561 Jan 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PatrykLucka @matthewwalsh0 - Would a more generic "yieldClaim" tx type make more sense here? My understanding here is that we'd like the custom tx type to easily display yield claims in the activity list + potentially having custom confirmation screens down the road. @PatrykLucka Please correct me if I'm wrong! 😄


/**
* A transaction that converts tokens to mUSD.
*/
Expand Down