Skip to content

Conversation

@PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Jan 26, 2026

Explanation

Adds a new merklYieldClaim transaction type to the TransactionType enum in the transaction controller. This enables the controller to properly categorize and handle transactions that claim yield rewards from Merkl Yield contracts (mUSD claim bonus). Without this type, Merkl yield claim transactions would fall under a generic category, making it harder to track and display them appropriately in the UI.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Adds a new transaction categorization for Merkl yield claims.

  • Extend TransactionType enum with merklYieldClaim in types.ts
  • Update CHANGELOG.md under Unreleased to record the new type

Written by Cursor Bugbot for commit b4380e5. This will update automatically on new commits. Configure here.

@PatrykLucka PatrykLucka self-assigned this Jan 26, 2026
@PatrykLucka PatrykLucka requested a review from a team as a code owner January 26, 2026 14:47
@PatrykLucka PatrykLucka requested a review from a team as a code owner January 26, 2026 14:48
/**
* A transaction that claims yield from a Merkl Yield contract.
*/
merklYieldClaim = 'merklYieldClaim',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary hold while we discuss use case.

Copy link
Contributor

@Matt561 Matt561 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PatrykLucka @matthewwalsh0 - Would a more generic "yieldClaim" tx type make more sense here? My understanding here is that we'd like the custom tx type to easily display yield claims in the activity list + potentially having custom confirmation screens down the road. @PatrykLucka Please correct me if I'm wrong! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants