Develop #38
Merged
Develop #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity - Updated Gradle wrapper to version 8.10 in gradle-wrapper.properties. - Modified .classpath files to include new source paths and updated JRE container to JavaSE-22. - Updated bnd.bnd files to reflect new bundle versions and dependencies. - Created build.gradle files for core, runner, itests, and testutil modules with necessary dependencies for JUnit 5, Mockito, and AssertJ. - Refactored integration test classes to use JUnit 5 annotations and assertions. - Updated various bundle versions across the project to SNAPSHOT versions for ongoing development. - Changed imports in LoginService and LoginTestService to use Jakarta EE packages. - Enhanced MultiReadHttpServletRequestWrapper to implement ReadListener interface. - Simplified settings.gradle for better project structure and clarity.
- Updated bundle configurations to remove Felix DM annotations and replace them with OSGi DS annotations. - Converted various components to use OSGi DS, including ClientServiceFactory, ExceptionLookup, and multiple security-related classes. - Removed the Activator classes that were previously used for Felix DM and added service properties for OSGi DS. - Adjusted service dependencies to use @reference annotations with appropriate cardinality and policies. - Cleaned up code by removing unnecessary comments and unused imports. - Deleted the PooledSqlServiceFactory class as part of the migration effort. - Updated settings.gradle to note the need for Felix DM migration in integration tests.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tency - Updated HelloService.java to enhance code formatting and maintain consistency in comments. - Refactored LoggedInFilter.java to improve readability and streamline token retrieval logic. - Cleaned up LoginService.java and LoginTestService.java for better formatting and consistency. - Enhanced MultiReadHttpServletRequestWrapper.java to improve readability and maintainability. - Simplified XDomainFilter.java by improving formatting and consistency in method implementations. - Refactored DataSourceObjectImpl.java and DataSourceRegistryImpl.java for better readability and consistency in logging. - Improved HandlerRegistryImpl.java by enhancing code structure and readability. - Updated PooledBasicDataSourceBuilderImpl.java to improve code clarity and maintainability. - Enhanced HandlerRegistryImplTest.java for better readability and consistency in test structure.
…aintainability - Updated LoginTestService to improve code formatting and structure. - Refactored MultiReadHttpServletRequestWrapper for better clarity and consistency. - Enhanced XDomainFilter for clearer CORS handling. - Improved DataSourceObjectImpl and DataSourceRegistryImpl for better logging and structure. - Refactored HandlerRegistryImpl to streamline request handling and improve readability. - Updated PooledBasicDataSourceBuilderImpl for better property management and logging. - Enhanced HandlerRegistryImplTest to improve test clarity and structure.
This change downgrades the project from JDK 22 to JDK 21 (LTS) for better long-term support and compatibility. JDK 21 is the latest LTS release and provides more stable support for production environments. Changes: - Update Gradle build configuration to target Java 21 - Update all .bnd files to use JavaSE-21 execution environment - Update documentation to reflect JDK 21 requirements - Update installation instructions across all documentation - Maintain all dependency versions (they support both JDK 21 and 22) Build and Runtime: - Project builds successfully with OpenJDK 21.0.8 - All executable JARs run correctly with JDK 21 - Integration tests have existing OSGi classpath issues (not related to JDK version) Documentation Updates: - README.md: Updated JDK requirements and installation instructions - DEVELOPER-SETUP.md: Updated IDE setup for JDK 21 - PRODUCTION-DEPLOYMENT.md: Updated deployment requirements for JDK 21 - QUICK-START.md: Updated quick start guide for JDK 21 - docs/README.md: Updated runtime requirements The project now uses JDK 21 LTS, providing a stable foundation for both development and production deployments while maintaining all modern Java features and performance improvements.
- Created OSGiIntegrationTest.java to test OSGi environment detection, service lookup, configuration updates, and service registration. - Implemented TestRunner.java for executing tests from the command line. - Updated bnd.bnd files to include necessary dependencies for JUnit and Jakarta JMS. - Added ClientServerTest.java to test ActiveMQ broker functionality with OpenWire and STOMP protocols. - Refactored existing code to replace javax.jms imports with jakarta.jms for compatibility with Jakarta EE. - Updated GossClient.java to streamline message handling for both OpenWire and STOMP protocols. - Enhanced server implementation classes to utilize Jakarta JMS imports.
- Removed the old TestRunner.java file and replaced it with a new implementation. - Added comprehensive integration tests for GOSS functionality, including BasicConnectionTest, CoreFunctionalityTest, GossEndToEndTest, GossOSGiEndToEndTest, and OSGiIntegrationTest. - Updated .classpath to include test source directories and dependencies. - Modified goss-core.bndrun to use JavaSE-21 and updated run bundles. - Updated bnd.bnd and goss-client.bnd to change dependency versions for Apache Shiro and other libraries. - Added a new META-INF/MANIFEST.MF file for JAXB implementation. - Enhanced test coverage for client-server communication, including publish/subscribe patterns and multiple protocol support. - Implemented service registration and configuration updates for OSGi environment tests.
…r Java 21 + Jakarta EE migration
Jdk 22 update
…onents, including security, server API, and test utilities. Update bundle versions to reflect the latest changes across the project, ensuring compatibility and improved functionality. Notable updates include the addition of security-ldap and security-propertyfile modules, as well as enhancements in the runner and test utilities.
Major Changes: - Bump all GOSS components to version 11.0.0-SNAPSHOT (synchronized versioning) - Port session renewal bug fix from master branch for improved stability - Add comprehensive JWT token authentication support - Add release management script for version control New Features: - JWT token authentication (opt-in via ClientFactory.create() useToken parameter) - Automatic JMS session renewal when publish operations fail - New security infrastructure: JWTAuthenticationToken, SecurityConfig, RoleManager, GossSecurityManager - Release script (release.sh) for managing SNAPSHOT/release versions Modified Components: - Updated all .bnd files with 11.0.0-SNAPSHOT versions - Updated packageinfo files (pnnl.goss.core, pnnl.goss.core.client, pnnl.goss.core.security) - Enhanced GossClient with token support and session renewal - Enhanced ClientFactory and ClientServiceFactory with token-aware client creation - Updated SecurityConstants with token-related properties New Files: - pnnl.goss.core/src/pnnl/goss/core/security/JWTAuthenticationToken.java - pnnl.goss.core/src/pnnl/goss/core/security/SecurityConfig.java - pnnl.goss.core/src/pnnl/goss/core/security/GossSecurityManager.java - pnnl.goss.core/src/pnnl/goss/core/security/RoleManager.java - pnnl.goss.core.itests/src/pnnl/goss/core/itests/ClientFactoryTokenTest.java - release.sh Testing: - All existing tests pass - New ClientFactoryTokenTest validates token authentication functionality - Backward compatibility maintained (existing code works without changes) Build Status: ✓ BUILD SUCCESSFUL 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…cripts Release Artifacts: - Add version 11.0.0 JARs for all GOSS components (14 artifacts) - Add version 10.x JARs from master (core-api 10.0.0 through 10.0.10) - Add version 9.x JARs from master (core-api 9.1.66, 9.1.9; security 9.0.0-9.0.4) Maintenance Scripts: - Add restore-jars.sh for restoring JARs from master branch - Add archive-old-versions.sh for managing version archival These artifacts prepare the repository for merge to master with complete version history across major versions 9, 10, and 11. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Updated SecurityManagerRealmHandler to log activation and manage realm registration more effectively. - Improved GossLDAPRealm with enhanced configuration handling, LDAP server connectivity checks, and detailed logging. - Refactored PropertyBasedRealm to include activation logging and improved property handling. - Modified GridOpticsServer to ensure proper configuration handling and added support for optional WebSocket transport. - Introduced scripts for managing GOSS artifact versions and pushing them to the repository, including version extraction and validation. - Added a Python script for pushing built JARs to the GOSS-Repository with detailed logging and dry-run capabilities. - Created a version management script to show, release, and snapshot versions of GOSS bundles.
…, security-propertyfile, and testutil - Added maven-metadata.xml files for new version 11.0.0 in pnnl.goss.core.runner, security-ldap, security-propertyfile, and testutil. - Introduced new JAR files for version 11.0.0 for pnnl.goss.core.runner, security-ldap, and security-propertyfile. - Removed outdated JAR files for versions 2.0.5, 2.0.6, 3.0.0 in pnnl.goss.core.runner and 1.0.5, 1.0.6, 2.0.0 in security-ldap. - Updated bundle versions in bnd files across various modules to 11.0.0. - Added a new script `check-api.py` for detecting API changes and suggesting version bumps. - Enhanced `version.py` script with commands for bumping versions (major, minor, patch) and managing snapshots.
- Added GossCli class for command-line interface to subscribe and publish messages. - Implemented support for both QUEUE and TOPIC destination types in the GOSS client. - Updated Client interface to include methods for handling different destination types. - Enhanced GossClient to manage subscriptions and publications based on destination type. - Modified build.gradle to include new CLI task for creating the goss-cli executable. - Removed outdated maven-metadata.xml files for various modules. - Updated security manager configuration to improve authorization caching. - Added unit tests for DESTINATION_TYPE enum to ensure correct behavior and stability. - Updated push-to-local-goss-repository.py script for better user feedback on JAR updates.
…ory to .gitignore
…d PropertyBasedRealm
- Updated classpath entries in .classpath to reflect new output directories and added additional source paths for annotation processing. - Added new dependencies in bnd.bnd for httpcore to ensure compatibility with existing components. - Updated goss-core-security.bnd to require the FileInstall bundle for proper configuration management. - Refactored GossLDAPRealm to extend DefaultLdapRealm instead of JndiLdapRealm, improving LDAP integration and functionality.
…cessary dependencies - Updated output paths for source entries from 'build/classes/java/test' to 'bin/test' and 'build/classes/java/main' to 'bin/main'. - Removed multiple redundant classpath entries for libraries and annotation processors. - Added gradle_scope and gradle_used_by_scope attributes to main source entry. - Retained necessary JRE and Gradle classpath container entries.
- Added index.xml.sha for release repository. - Introduced new JAR files for the following components: - pnnl.goss.core.core-api - pnnl.goss.core.goss-client - pnnl.goss.core.goss-core-commands - pnnl.goss.core.goss-core-exceptions - pnnl.goss.core.goss-core-security - pnnl.goss.core.goss-core-server-api - pnnl.goss.core.goss-core-server-registry - pnnl.goss.core.goss-core-server-web - pnnl.goss.core.goss-core-server - pnnl.goss.core.itests - pnnl.goss.core.runner - pnnl.goss.core.security-ldap - pnnl.goss.core.security-propertyfile - pnnl.goss.core.testutil
- Added logging for consumer creation and message handling in DefaultClientConsumer and DefaultClientListener. - Improved message processing in DefaultClientListener to handle BytesMessage and log unhandled message types. - Updated Activator to manage GossRealm services dynamically, ensuring immediate authentication capability upon activation.
- Updated SHA for index.xml - Updated existing JAR files for pnnl.goss.core.core-api, pnnl.goss.core.goss-client, pnnl.goss.core.goss-core-commands, pnnl.goss.core.goss-core-exceptions, pnnl.goss.core.goss-core-security, pnnl.goss.core.goss-core-server-api, pnnl.goss.core.goss-core-server-registry, pnnl.goss.core.goss-core-server-web, pnnl.goss.core.goss-core-server, pnnl.goss.core.itests, pnnl.goss.core.runner, pnnl.goss.core.security-ldap, pnnl.goss.core.security-propertyfile, and pnnl.goss.core.testutil to version 12.1.0. - Added new JAR files for version 12.1.0 for pnnl.goss.core.core-api, pnnl.goss.core.goss-client, pnnl.goss.core.goss-core-commands, pnnl.goss.core.goss-core-exceptions, pnnl.goss.core.goss-core-security, pnnl.goss.core.goss-core-server-api, pnnl.goss.core.goss-core-server-registry, pnnl.goss.core.goss-core-server-web, pnnl.goss.core.goss-core-server, pnnl.goss.core.itests, pnnl.goss.core.runner, pnnl.goss.core.security-ldap, pnnl.goss.core.security-propertyfile, and pnnl.goss.core.testutil. - Updated bundle versions in bnd files to 12.1.0 for core-api, goss-client, goss-core-commands, goss-core-exceptions, goss-core-security, goss-core-server-api, goss-core-server-registry, goss-core-server-web, goss-core-server, security-ldap, and security-propertyfile.
Update for security
Resolved modify/delete conflicts by keeping develop's deletions: - Removed old release repo jars that were deleted in develop - Removed EchoCommands.java and web Activator.java that were deleted in develop
craig8
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.