Optimize getFeedOptions internal computation

[MelvinBot]

Explanation of Change

Optimizes the internal computation of getFeedOptions by eliminating repeated object allocations and redundant work in its call chain. The ~12ms per-render cost came from several compounding inefficiencies:

1. getBankName allocated a 17-entry feedNamesMapping object and its keys array on every call, then ran a linear .find() scan. The CSV early-exit check also ran after the scan instead of before it. Now the mapping and keys are hoisted to module scope (allocated once at import), and CSV feeds exit before the scan.

2. isCustomFeed allocated a new 3-element array on every call. Now hoisted to a module-scope CUSTOM_FEED_PREFIXES constant.

3. buildFeedKeysWithAssignedCards used rest spread destructuring (const {cardList, ...assignedCards} = cards) per workspace card entry, creating a new object just to check if it had any keys. Replaced with a lightweight Object.keys(cards).some(k => k !== 'cardList') check that avoids the allocation.

4. getCardFeedsForDisplay was called inside a .reduce() loop in SearchQueryUtils.ts — once per feed filter value. Hoisted outside the loop so it runs once.

Fixed Issues

$ #82422
PROPOSAL: #82422 (comment)

Tests

1. Navigate to the Search page and open the filters bar
2. Apply a feed filter and verify the correct feed options are displayed
3. Switch between different filter values and verify the UI responds correctly
4. Verify that no errors appear in the JS console

• Verify that no errors appear in the JS console

Offline tests

These changes are to pure utility functions that compute feed display options from in-memory Onyx data. No network calls are involved, so offline behavior is unchanged.

QA Steps

1. Navigate to the Search page
2. Open the filters bar and verify feed options load correctly
3. Apply feed filters and verify results update properly
4. Verify no errors in the JS console

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - No UI changes, internal computation optimization only

Android: mWeb Chrome

N/A - No UI changes, internal computation optimization only

iOS: Native

N/A - No UI changes, internal computation optimization only

iOS: mWeb Safari

N/A - No UI changes, internal computation optimization only

MacOS: Chrome / Safari

N/A - No UI changes, internal computation optimization only

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/CardUtils.ts	78.40% <100.00%> (+0.08%)	⬆️
src/selectors/Card.ts	100.00% <100.00%> (ø)
src/libs/SearchQueryUtils.ts	71.42% <0.00%> (ø)
... and 3 files with indirect coverage changes

[hoangzinh]

@MelvinBot I tried measuring performance again, and it has decreased from 0.76 ms to 0.36 ms on my local environment. Is there any other room for improvement?

[MelvinBot]

Great work on the ~52% improvement (0.76ms → 0.36ms). There are a few more optimization opportunities I identified — though at 0.36ms you're already in a good spot, so these would be diminishing returns:

Higher Impact

1. Redundant getCardFeedsForDisplay calls in SearchQueryUtils.ts — getFilterDisplayValue (line ~1162) calls getCardFeedsForDisplay for every individual feed filter value via the .map() at line ~1238. So if there are N feed filter values, it runs N times on top of the call you already hoisted. Computing it once and threading the result through (or adding a simple function-level cache) would eliminate O(N) redundant recomputations.

2. useFeedKeysWithAssignedCards lacks memoization — buildFeedKeysWithAssignedCards runs on every render without useMemo or being passed as a selector to useOnyx. This hook is consumed by ~12 files, so wrapping it in useMemo (keyed on allWorkspaceCards) or passing the builder as a selector would avoid repeated work across re-renders.

Lower Impact

3. getCardFeedIcon allocates a 16-key feedIcons object on every call (line ~417-435) — same pattern as the feedNamesMapping you already hoisted. Could be hoisted to module scope if the illustrations/companyCardIllustrations params are stable, or restructured as a function that avoids the full-object allocation.

4. isDirectFeed(key) called twice for the same key in getOriginalCompanyFeeds (lines ~534-542) — caching the result in a local variable (const isDirect = isDirectFeed(key)) avoids redundant .toLowerCase() + .startsWith() calls per iteration.

5. Minor: CUSTOM_FEEDS (line ~941) duplicates CUSTOM_FEED_PREFIXES (line ~460) — identical arrays under different names. Consolidating avoids future divergence.

Items 1 and 2 are the ones most likely to yield measurable gains. Items 3-5 are micro-optimizations that are worth doing if you're already in the area but probably won't show up in benchmarks individually.

That said, 0.36ms is already fast for this kind of utility — unless profiling shows this function is called very frequently per render cycle (e.g., dozens of times due to the getFilterDisplayValue issue in item 1), the current improvements may be sufficient.

[MelvinBot]

The only failing check is PR Reviewer Checklist / checklist, which fails because no reviewer has posted their checklist comment yet. This is not related to the code changes — all code checks (ESLint, typecheck, Prettier, tests, builds, spellcheck, etc.) are passing.

This check will resolve automatically once a reviewer posts their reviewer checklist on the PR. No code fix is needed.

[MelvinBot]

The only failing check is PR Reviewer Checklist / checklist, which fails because no reviewer has posted a reviewer checklist comment yet. This is not a code issue — it's a standard workflow check that will pass once a reviewer posts their checklist during the review process.

All other checks are either passing or still pending (tests, typecheck, ESLint, builds, etc.). No code fix is needed.

[MelvinBot]

The only failing check is PR Reviewer Checklist (checklist), which fails because no reviewer has posted the reviewer checklist comment yet. This is not a code issue — it will resolve automatically once a reviewer posts their checklist.

All code-related checks (ESLint, typecheck, Prettier, builds, verifySignedCommits, spellcheck) are passing. Tests and perf-tests are still pending.

[hoangzinh]

@luacmartins, if you have an account that makes getFeedOptions take ~12ms per-render. Can you try to measure it again on this PR?

[luacmartins]

I do, but I've been trying to get a trace for the past 30min and the profiler keeps crashing on that account 😂

[luacmartins]

I wasn't able to get a profile in an account, but I wrote perf tests to verify these changes. Here are the results:

 - SearchUIUtils [SearchUIUtils] getFeedOptions with feedKeysWithCards [function]: 1.2 ms → 0.1 ms (-1.1 ms, -90.7%) 🟢 | 1 → 1
 - SearchUIUtils [SearchUIUtils] getFeedOptions with large dataset [function]: 23.5 ms → 1.0 ms (-22.5 ms, -95.8%) 🟢 | 1 → 1
 - SearchUIUtils [SearchUIUtils] getFeedOptions without feedKeysWithCards [function]: 1.0 ms → 0.1 ms (-0.9 ms, -91.0%) 🟢 | 1 → 1

I think this one is specially significant:
getFeedOptions with large dataset [function]: 23.5 ms → 1.0 ms (-22.5 ms, -95.8%)

[luacmartins]

@hoangzinh I think we can go ahead with this PR given the measurements above

[melvin-bot]

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[MelvinBot]

The only failing check is PR Reviewer Checklist — it's failing because no reviewer has posted the reviewer checklist comment yet. This is not a code issue and requires no code fix.

All code-related checks are passing: ESLint, typecheck, Prettier, all 8 test jobs, builds (iOS/Android/desktop/web), perf-tests, spellcheck, verifySignedCommits, codecov, and CLA.

[hoangzinh]

@hoangzinh I think we can go ahead with this PR given the measurements above

sure, I will try to complete checklist today

[hoangzinh]

@MelvinBot can you resolve conflicts?

[melvin-bot]

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[MelvinBot]

Resolved the merge conflict in src/libs/CardUtils.ts. The conflict was between:

• This PR's change: hoisting feedNamesMapping to module scope
• Main's change: updating the PEX entry to NON_CONNECTABLE_BANKS.PEX, adding NonConnectableBankName to the type, and removing the EXPENSIFY_CARD.BANK entry

The resolution keeps both: the module-scope hoisting from this PR and the PEX/type updates from main.

[MelvinBot]

The failing checks on this PR are not related to the code changes and don't require a code fix:

1. checklist — Fails because no reviewer has posted the PR Reviewer Checklist yet. This resolves itself once a reviewer posts their checklist.

2. build (Debug, true) and build (Expensify Dev, Debug, true) — These are failing due to a Node engine version mismatch on the macOS CI runners (required: node 20.19.5, actual: node v20.20.0). This is a pre-existing infrastructure issue — the same two checks are also failing on other recent PRs (e.g. Use Math.abs for taxable amount in negative expense tax calculation #83643).

All code-related checks are passing: tests (all 8 jobs), typecheck, ESLint, Prettier, spellcheck, builds on non-macOS runners, and Storybook tests.

[MelvinBot]

The failing checks are unrelated to this PR's code changes.

Failing checks:

• build (Debug, true) — Android native build
• build (Expensify Dev, Debug, true) — iOS native build
• checklist — PR author checklist (not actionable)

Root cause: The Mobile-Expensify submodule's package.json enforces node 20.19.5, but the CI runners now have node v20.20.0. This causes an EBADENGINE error during postInstall.sh when installing node modules in the submodule.

Evidence this is unrelated:

• This PR only modifies src/libs/CardUtils.ts, src/libs/SearchQueryUtils.ts, and src/selectors/Card.ts — no build config or submodule changes
• The Mobile-Expensify submodule pointer is identical on this branch and main (commit fdd2355)
• The same two builds are also failing on other open PRs (e.g. Use Math.abs for taxable amount in negative expense tax calculation #83643)

This will likely resolve when the Mobile-Expensify submodule's engine constraint is updated to allow node 20.20.0, or when CI runners are pinned back to 20.19.5.

[hoangzinh]

@MelvinBot can you try to merge the latest main? It was probably fixed

[hoangzinh]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-27.at.15.46.14.mov

Android: mWeb Chrome

Screen.Recording.2026-02-27.at.15.42.33.mov

iOS: HybridApp

Screen.Recording.2026-02-27.at.15.53.51.mov

iOS: mWeb Safari

Screen.Recording.2026-02-27.at.15.55.05.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-27.at.15.39.47.mov

[MelvinBot]

Done — merged the latest main into this branch and pushed. No conflicts. The CI checks should re-run now.

[hoangzinh]

LGTM 🚢

[hoangzinh]

@luacmartins all yours