[$250] [Performance] Optimize getFeedOptions (~12ms per render)

[luacmartins]

Problem

getFeedOptions takes ~12ms per render and contributes to slow Reports page navigation.

Solution

Optimize the function (e.g. memoization, caching, or reducing work per call). Use React Profiler / Chrome DevTools to validate improvements.

Issue Owner

Current Issue Owner: @hoangzinh

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022024628997402879583
• Upwork Job ID: 2024628997402879583
• Last Price Increase: 2026-02-19

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022024628997402879583

[BrandonS7]

I'd like to propose a fix for this.

Problem:
Currently, feedOptions and the selected feed value are calculated in a single useMemo in SearchFiltersBar.tsx. This useMemo includes flatFilters in its dependency array. As a result, the expensive getFeedOptions function (which iterates over all card feeds) re-runs every time flatFilters changes—even when the underlying feed data hasn't changed.

Solution:
Split the memoization into two parts:

1. Memoize feedOptions separately, depending only on the data sources (allFeeds, personalAndWorkspaceCards, etc.).
2. Memoize the selected feed value separately, depending on flatFilters and the computed feedOptions.

This ensures getFeedOptions only runs when the actual feed data updates, eliminating the ~12ms overhead on other filter interactions.

[melvin-bot]

📣 @BrandonS7! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[BrandonS7]

Contributor details
Your Expensify account email: brandon@starboardinvestments.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b9f96e8d15d7850e

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[luacmartins]

@BrandonS7 we already updated the SearchFiltersBar component so it's now auto-memoized by React compiler. That resulted in the removal of the useMemo hook and the dependency array altogether. This issue is focused on improving the computation and performance of getFeedOptions, not its usage.