-
Notifications
You must be signed in to change notification settings - Fork 477
perf(profiling): re-add interning #16276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
perf(profiling): re-add interning #16276
Conversation
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
cc817b5 to
7ac56b0
Compare
Performance SLOsComparing candidate kowalski/revert-fix-profiling-revert-intern-strings-functions-into-libdatadog (55ef322) with baseline main (343c6be) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 491.301µs (SLO: <700.000µs 📉 -29.8%) vs baseline: 📈 +15.0% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 429.559µs (SLO: <700.000µs 📉 -38.6%) vs baseline: -0.7% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 632.980µs (SLO: <700.000µs -9.6%) vs baseline: -0.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 638.376µs (SLO: <700.000µs -8.8%) vs baseline: -0.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 350.830µs (SLO: <700.000µs 📉 -49.9%) vs baseline: +0.8% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 359.502µs (SLO: <700.000µs 📉 -48.6%) vs baseline: -0.4% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 493.824µs (SLO: <700.000µs 📉 -29.5%) vs baseline: -0.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 504.433µs (SLO: <700.000µs 📉 -27.9%) vs baseline: -0.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 375.029µs (SLO: <700.000µs 📉 -46.4%) vs baseline: -1.0% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.7% ✅ ospathsplitdrive_noaspectTime: ✅ 73.063µs (SLO: <700.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 460.028µs (SLO: <700.000µs 📉 -34.3%) vs baseline: +0.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 463.865µs (SLO: <700.000µs 📉 -33.7%) vs baseline: -0.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.390µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +17.7% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 204.970µs (SLO: <220.000µs -6.8%) vs baseline: +0.3% Memory: ✅ 35.488MB (SLO: <38.000MB -6.6%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.235µs (SLO: <20.000µs 📉 -83.8%) vs baseline: ~same Memory: ✅ 35.488MB (SLO: <38.000MB -6.6%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.838µs (SLO: <230.000µs -6.6%) vs baseline: +0.3% Memory: ✅ 35.448MB (SLO: <38.000MB -6.7%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.143µs (SLO: <20.000µs 📉 -89.3%) vs baseline: -1.0% Memory: ✅ 35.468MB (SLO: <38.000MB -6.7%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.317µs (SLO: <150.000µs -9.1%) vs baseline: +0.2% Memory: ✅ 35.468MB (SLO: <38.000MB -6.7%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.030µs (SLO: <20.000µs 📉 -84.9%) vs baseline: -1.0% Memory: ✅ 35.448MB (SLO: <38.000MB -6.7%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 218.386µs (SLO: <250.000µs 📉 -12.6%) vs baseline: ~same Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.615ms (SLO: <22.000ms -6.3%) vs baseline: ~same Memory: ✅ 35.448MB (SLO: <38.000MB -6.7%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.239ms (SLO: <2.550ms 📉 -12.2%) vs baseline: ~same Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +5.2% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: +0.4% Memory: ✅ 35.507MB (SLO: <38.000MB -6.6%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.256ms (SLO: <2.550ms 📉 -11.5%) vs baseline: +0.3% Memory: ✅ 35.448MB (SLO: <38.000MB -6.7%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.527µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +1.0% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 174.387µs (SLO: <250.000µs 📉 -30.2%) vs baseline: -0.5% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +4.8% ✅ flush-1000-metricsTime: ✅ 2.200ms (SLO: <2.500ms 📉 -12.0%) vs baseline: +0.5% Memory: ✅ 36.333MB (SLO: <38.750MB -6.2%) vs baseline: +4.9% 🟡 Near SLO Breach (1 suite)🟡 tracer - 6/6✅ largeTime: ✅ 31.568ms (SLO: <32.950ms -4.2%) vs baseline: -0.2% Memory: ✅ 36.844MB (SLO: <39.250MB -6.1%) vs baseline: +4.7% ✅ mediumTime: ✅ 3.135ms (SLO: <3.200ms -2.0%) vs baseline: +0.5% Memory: ✅ 35.173MB (SLO: <38.750MB -9.2%) vs baseline: +4.7% ✅ smallTime: ✅ 365.556µs (SLO: <370.000µs 🟡 -1.2%) vs baseline: +3.7% Memory: ✅ 35.232MB (SLO: <38.750MB -9.1%) vs baseline: +4.9%
|
7ac56b0 to
c427efd
Compare
c427efd to
55ef322
Compare
Description
Testing
Risks
Additional Notes