updated browser filters rules to be more flexible #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erwise all links point to safelinks.protction.outlook.com
…tes like bitly.com and tinyurl.com to detect actual URL. Never = do not follow URLs (existing functionality) First Redirect = only follow one redirect All Redirects = Follow all redirects to determine the "final" URL. Best for pattern matching but slightly worse on performance.
* UI displayed while loading * Only follow redirects for known URL shortners (need to make this list user configurable) * Added a timeout * Follow a maximum of 20 redirects * User "cancelable"
* Added ability to choose comparitor (Ends with, contains, regex, etc) * Added ability to compare domain, HTTP path, or full URL * Changed rules to be stored in Json format * Added auto import and conversion from old rule format Removed LeaveDotsAndSlashesEscaped() doesn't seem to be required any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated browser filters rules to be more flexible:
Removed LeaveDotsAndSlashesEscaped() doesn't seem to be required after .net upgrade.
This PR builds on my earlier PR URL expander PR (includes all the changes from that PR):
#86