add test for except star#237
Merged
dataflake merged 14 commits intozopefoundation:masterfrom Nov 2, 2022
Merged
Conversation
loechel
requested changes
Oct 15, 2022
Member
loechel
left a comment
loechel
left a comment
There was a problem hiding this comment.
see specific comments for changes
icemac
requested changes
Oct 26, 2022
Member
icemac
left a comment
icemac
left a comment
There was a problem hiding this comment.
I am not sure whether we actually need to support this new esoteric syntax: I've never had a need for it over all the years. But as it seems easy to support it, let's keep it.
The only additional change request I have is a change log entry.
Co-authored-by: Michael Howitz <mh@gocept.com>
Member
|
The code looks good now. The change log entry is still requested. Maybe we have to lower the required code coverage, so the tests can pass. (Instead of waiting for #238.) |
loechel
requested changes
Oct 28, 2022
Member
loechel
left a comment
loechel
left a comment
There was a problem hiding this comment.
@eikichi18 can you please also add a changelog entry in CHANGES.rst,
Contributor
Author
|
Done |
loechel
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for except star