Merged
Conversation
The show_menu() function now supports menus without a title by setting the title parameter to None or some other falsy value like an empty string.
The instructions for the "zmk init" command sometimes led to confusion because the first thing it asks you for is a repo URL, but new users need to skip past that prompt to get instructions for creating a new repo. To improve this, we now start with a prompt to ask the user whether they want to create a new repo or clone an existing one. Additionally, opening the page to create a repo from a template in a web browser may fail if the webbrowser module can't identify any installed browsers. If that happens, we now print the link so the user can manually open the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instructions for the
zmk initcommand sometimes led to confusion because the first thing it asks you for is a repo URL, but new users need to skip past that prompt to get instructions for creating a new repo. To improve this, we now start with a prompt to ask the user whether they want to create a new repo or clone an existing one.Additionally, opening the page to create a repo from a template in a web browser may fail if the webbrowser module can't identify any installed browsers. If that happens, we now print the link so the user can manually open the page.