Remove use of shell in subprocess call#30
Closed
gnodar01 wants to merge 1 commit intozmkfirmware:mainfrom
Closed
Conversation
- Resolves issue zmkfirmware#27 - use of shell=True requires a string, not a list, and also has some security considerations: https://docs.python.org/3.10/library/subprocess.html#security-considerations
Collaborator
|
IIRC, the reason for shell=True was so that you didn't have to specify the full path of the editor, e.g. Does this work without the full path specified? |
Collaborator
|
On Windows, removing |
joelspadin
requested changes
Jul 27, 2025
Collaborator
joelspadin
left a comment
joelspadin
left a comment
There was a problem hiding this comment.
With
zmk config core.editor "code"
running zmk code with this change on Windows results in a FileNotFoundError. With shell=False, this calls _winapi.CreateProcess(), which doesn't search the PATH for the program.
Collaborator
|
Fixed on all OSes in #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes it for myself, but there may have been a good reason for using
shell=True, so understandable if this simple "fix" isn't suitable.