Open
Conversation
Contributor
|
Related: #87 |
doesn't cache the output of the proc macro, and using the derive form of this code can cause slowdowns in `cargo check` and `rust-analyzer`. As an alternative, this commit introduces an option to generate the `PrimeField` implementation in a `build.rs` script, to avoid the slowdown.
Member
|
This PR is now almost entirely the codegen changes, which cannot be reviewed in the same PR as the trait changes. So I'm going to make my own PR on top of #93 that adds the associated constants, and we can use that to investigate the ecosystem and confirm whether it will cause any issues for downstream trait implementors (#87 (comment)). |
Member
str4d
changed the title
zero, one, and multiplicative_generator as constantsThe latter was causing issues for type inference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR exposes the
zero,one, andmultiplicative_generatorvalues as constants rather than functions. It might be preferred to only have the constants version---and I'm happy to make that change if so---but for now I've left the original function versions as well.