Skip to content

Fix async/event lifecycle edge cases#687

Open
dmulcahey wants to merge 1 commit intodevfrom
pr/fix-async-event-lifecycle
Open

Fix async/event lifecycle edge cases#687
dmulcahey wants to merge 1 commit intodevfrom
pr/fix-async-event-lifecycle

Conversation

@dmulcahey
Copy link
Contributor

Summary

Fixes async lifecycle edge cases in concurrency limiting, periodic polling cancellation, and async event listener handling.

Failing tests addressed

  • tests/test_async_.py::test_gather_with_limited_concurrency_zero_limit_rejected
  • tests/test_async_.py::test_periodic_cancellation_propagates
  • tests/test_event.py::test_event_base_once_async_multiple_emits_same_tick
  • tests/test_event.py::test_event_base_emit_async_callable_object

Verification

  • pytest (branch-local targeted run): all listed tests pass.

@dmulcahey dmulcahey force-pushed the pr/fix-async-event-lifecycle branch from 39cf3cf to 1f15a84 Compare February 27, 2026 16:04
@dmulcahey dmulcahey changed the base branch from dm/codex-issue-exploration to dev February 27, 2026 16:04
@dmulcahey dmulcahey closed this Feb 27, 2026
@dmulcahey dmulcahey reopened this Feb 27, 2026
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (9d03d63) to head (1f15a84).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #687      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files          62       62              
  Lines       10949    10947       -2     
==========================================
- Hits        10677    10675       -2     
  Misses        272      272              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmulcahey
Copy link
Contributor Author

dmulcahey commented Feb 27, 2026

for:

Updated the periodic decorator to re-raise CancelledError instead of swallowing it, ensuring correct cancellation propagation for periodic tasks.

Is this one we were preventing propagation of on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant