Bug fix: Install yaml.h to INSTALL_INCLUDE_DIR#244
Open
sloretz wants to merge 1 commit intoyaml:masterfrom
Open
Bug fix: Install yaml.h to INSTALL_INCLUDE_DIR#244sloretz wants to merge 1 commit intoyaml:masterfrom
sloretz wants to merge 1 commit intoyaml:masterfrom
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake build has a variable
INSTALL_INCLUDE_DIRthat controls the folder headers get installed to. It appears the intent is to allow installing the header to a different folder usingcmake -DINSTALL_INCLUDE_DIR=..., and the include directory on the exportedyamltarget reflects that.Unfortunately, the actual
install()command ignores it and hard codesinclude. This PR fixes that bug.