Conversation
for more information, see https://pre-commit.ci
… read_netcdf do return Delayed objects
aulemahal
approved these changes
Jul 31, 2023
Contributor
aulemahal
left a comment
aulemahal
left a comment
There was a problem hiding this comment.
Sorry for the delay, this had fallen in some cracks.
Looks good. Do you want to precise the level of parallelization in the docstring of open_ncml ? (Like that aggregations are individually processed in parallel ? ) Or is it rare that a ncml has more than one "Aggregation" node ?
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
parallelis True,open_datasetis called using dask.delayed.