added option for variable pin length#48
Open
digitalhoax wants to merge 2 commits intoxPutnikx:masterfrom
Open
Conversation
Owner
|
hi @digitalhoax , I see the point of having a flexible length, it makes sense, I will test your solution first to make sure it doesn't add unnecessary complexity to the package. |
Owner
|
I guess some limitation should be added to prevent user from entering way too many symbols. For example Samsung limits up to 16 digits, with the current default dot size seems like 12 items fit the best. |
Author
|
Yes, this seems an obvious improvement that needs to be made. Will get to it shortly and update the PR accordingly. |
Author
|
I have limited the maximum number of chars to ten as that is what fits on some of my test devices' screen. Might be an option to decrease the font size on longer pins if the need for it arises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds the option to have a variable pin length. it adjusts the displayed dots accordingly and has a confirm button so you can confirm the pin.