Fix to avoid lastEnableArguments to be set to null due to cancelOnLeavePiP call#36
Open
dev-aman wants to merge 2 commits intowrbl606:mainfrom
Open
Fix to avoid lastEnableArguments to be set to null due to cancelOnLeavePiP call#36dev-aman wants to merge 2 commits intowrbl606:mainfrom
dev-aman wants to merge 2 commits intowrbl606:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that lastEnableArguments is set only after cancelOnLeavePiP() completes, preventing it from being cleared by that call.
- Removed the early assignment of
lastEnableArgumentsat the start ofenable() - Added assignment of
lastEnableArgumentsaftercancelOnLeavePiP()with a descriptive comment
Comments suppressed due to low confidence (2)
lib/src/floating.dart:144
- [nitpick] Add a unit test to verify that after calling
enable(),lastEnableArgumentsretains the passed arguments and is not reset bycancelOnLeavePiP().
lastEnableArguments = arguments;
lib/src/floating.dart:142
- [nitpick] The comment could be more concise. For example: "Assign
lastEnableArgumentsaftercancelOnLeavePiP()to avoid it being overridden."
// Moved this here as setting it on the first line does not make sense since
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix to avoid lastEnableArguments to be set to null due to cancelOnLeavePiP call
Why
This will avoid the case where pip status is always disabled and not automatic when it should be automatic post pip is enabled but not visible. (with respect to on LeavePIP)