Skip to content

Restore Retina Support (via WP Retina 2x, aka Perfect Images, plugin compat) #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iCaspar wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Restore Retina Support (via WP Retina 2x, aka Perfect Images, plugin compat) #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6587bb3
Add code for WPR2x that was removed from 68c489b4
iCaspar Jan 26, 2022
de402a0
Update namespacing, classnames and autoloading
iCaspar Jan 31, 2022
48bce9e
Use Imagify_Filesystem
iCaspar Jan 31, 2022
4ffeb21
Add back js assets previously removed
iCaspar Jan 31, 2022
33b21c3
Use min WP version 5.3 for phpcs
iCaspar Feb 2, 2022
77d4753
Import used trait in Media\WP class
iCaspar Feb 2, 2022
b45a06b
Import used trait in AbstractProcess
iCaspar Feb 2, 2022
f8e7761
Add PerfectImages methods for retina generation
iCaspar Feb 2, 2022
1063b72
Add methods for deleting retinas
iCaspar Feb 4, 2022
a4e0adb
Add re-optimization of images after regeneration
iCaspar Feb 4, 2022
33c212f
Remove unused js assets
iCaspar Feb 7, 2022
3ee9a92
Remove PerfectImagesCore
iCaspar Feb 7, 2022
773e60e
Remove PerfectImagesCore from main class
iCaspar Feb 7, 2022
1107dc0
Clean up comments and spacing
iCaspar Feb 7, 2022
05f3d8a
Extract assignments from within comparisons
iCaspar Feb 7, 2022
830c391
Update PerfectImages class docblock
iCaspar Feb 7, 2022
c8cc135
Check for 3rd-party function before using it
iCaspar Feb 8, 2022
e4eff0d
Use array_keys to get size names directly
iCaspar Feb 8, 2022
a9ab001
Extract can_restore_original() method
iCaspar Feb 8, 2022
142fd83
Extract add_webp_sizes() to helper method
iCaspar Feb 8, 2022
8fc613f
Check for new upload before doing retina process
iCaspar Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion classes/Media/WP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?php
namespace Imagify\Media;

use Imagify\Deprecated\Traits\Media\WPDeprecatedTrait;

defined( 'ABSPATH' ) || die( 'Cheatin’ uh?' );

/**
Expand All @@ -10,7 +12,7 @@
* @author Grégory Viguier
*/
class WP extends AbstractMedia {
use \Imagify\Deprecated\Traits\Media\WPDeprecatedTrait;
use WPDeprecatedTrait;

/**
* Tell if we’re playing in WP 5.3’s garden.
Expand Down
3 changes: 2 additions & 1 deletion classes/Optimization/Process/AbstractProcess.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php
namespace Imagify\Optimization\Process;

use Imagify\Deprecated\Traits\Optimization\Process\AbstractProcessDeprecatedTrait;
use Imagify\Job\MediaOptimization;
use Imagify\Optimization\Data\DataInterface;
use Imagify\Optimization\File;
Expand All @@ -14,7 +15,7 @@
* @author Grégory Viguier
*/
abstract class AbstractProcess implements ProcessInterface {
use \Imagify\Deprecated\Traits\Optimization\Process\AbstractProcessDeprecatedTrait;
use AbstractProcessDeprecatedTrait;

/**
* The suffix used in the thumbnail size name.
Expand Down
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"Imagify\\ThirdParty\\EnableMediaReplace\\": "inc/3rd-party/enable-media-replace/classes/",
"Imagify\\ThirdParty\\FormidablePro\\": "inc/3rd-party/formidable-pro/classes/",
"Imagify\\ThirdParty\\NGG\\": "inc/3rd-party/nextgen-gallery/classes/",
"Imagify\\ThirdParty\\PerfectImages\\": "inc/3rd-party/perfect-images/classes",
"Imagify\\ThirdParty\\RegenerateThumbnails\\": "inc/3rd-party/regenerate-thumbnails/classes/",
"Imagify\\ThirdParty\\WPRocket\\": "inc/3rd-party/wp-rocket/classes/"
},
Expand Down
1 change: 1 addition & 0 deletions inc/3rd-party/3rd-party.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
require IMAGIFY_PATH . 'inc/3rd-party/enable-media-replace/enable-media-replace.php';
require IMAGIFY_PATH . 'inc/3rd-party/formidable-pro/formidable-pro.php';
require IMAGIFY_PATH . 'inc/3rd-party/nextgen-gallery/nextgen-gallery.php';
require IMAGIFY_PATH . 'inc/3rd-party/perfect-images/wp-retina-2x.php';
require IMAGIFY_PATH . 'inc/3rd-party/regenerate-thumbnails/regenerate-thumbnails.php';
require IMAGIFY_PATH . 'inc/3rd-party/screets-lc.php';
require IMAGIFY_PATH . 'inc/3rd-party/wp-real-media-library.php';
Expand Down
Loading