Skip to content

Prevent exception when dynamically extending a class to add behaviors. #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeTowers merged 3 commits into from
Feb 20, 2026
Merged

Prevent exception when dynamically extending a class to add behaviors. #225

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07a128f
make sure implement array properties are unique
mjauvin Feb 20, 2026
7d03dbe
prevent duplication in extendableCallStatic for consistency
mjauvin Feb 20, 2026
3196946
Merge branch 'develop' into fix-implement
LukeTowers Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Extension/ExtendableTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function extendableConstruct()
return;
}

foreach ($uses as $use) {
foreach (array_unique($uses) as $use) {
$useClass = $this->extensionNormalizeClassName($use);

/*
Expand Down Expand Up @@ -489,7 +489,7 @@ public static function extendableCallStatic($name, $params = null)
throw new Exception(sprintf('Class %s contains an invalid $implement value', $className));
}

foreach ($uses as $use) {
foreach (array_unique($uses) as $use) {
// Class alias checks not required here as the current name of the extension class doesn't
// matter because as long as $useClassName is able to be instantiated the method will resolve
$useClassName = str_replace('.', '\\', trim($use));
Expand Down