Open
Conversation
Rich comments are often used as a scratchpad where forms are added and removed frequently. Allowing the closing parenthesis to be placed on a new line, aligned with the indentation of the block, makes these edits cleaner and keeps the diffs focused on the actual code changes. This commit adds the :indent-rich-comments? option, which: - Ensures a trailing newline exists in rich comments when enabled. - Prevents the removal of this newline during whitespace cleanup. - Aligns the closing parenthesis with the block's indentation. Fixes weavejester#365.
jramosg
force-pushed
the
feature/indent-rich-comments
branch
from
e1a9437 to
1cab794
Compare
Owner
|
This option should default to I'm also unsure if this is the right way to go about this feature. Let me give it some thought, but my initial idea is it might be worth having a list of forms that ignore certain rules. |
Contributor
Author
|
we could have something like: {:rule-exceptions {comment #{:gather-trailing-parens}}}what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rich comments are often used as a scratchpad where forms are added and removed frequently. Allowing the closing parenthesis to be placed on a new line, aligned with the indentation of the block, makes these edits cleaner and keeps the diffs focused on the actual code changes.
This commit adds the :indent-rich-comments? option, which:
Fixes #365.