Open
Conversation
Requirement "The isBalanced method returns true if the tree is a balanced binary search tree." in this particular case will be always false, becuse assert for this challenge returns test.isBalanced() which will be negative and therefore assert itself as well. Commit should fix the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement "The isBalanced method returns true if the tree is a balanced binary search tree." in this particular case will be always false, becuse assert for this challenge returns test.isBalanced() which will be negative and therefore assert itself as well.
Commit should fix the problem.
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Closes #XXXXX
Description
By default in Data Structures: Find the Minimum and Maximum Height of a Binary Search Tree challenge, method isBalanced() for provided data will return FALSE.
In data-structures.json, assert for this particular test contains `return test.isBalanced()' which will return FALSE by default for this data and test will fail.
Change from
test.isBalanced()to!test.isBalanced()should fix it.