-
Notifications
You must be signed in to change notification settings - Fork 3
🎉 Basic treasury structure intro (no functionality, just basic hello world structure) #168
base: fees-v3-rebroadcast
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the basic treasury plugin structure to the project, adding configuration, Docker containerization, and core plugin functionality without implementing actual business logic.
- Adds treasury plugin Go code with basic interface implementations
- Creates Docker configurations for treasury server and worker services
- Establishes database and Redis infrastructure for treasury operations
Reviewed Changes
Copilot reviewed 23 out of 31 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/treasury/*.go | Core treasury plugin implementation with config, handlers, and interface compliance |
| cmd/treasury/* | Main entry points for treasury server and worker applications |
| treasury.*.example.json | Example configuration files for treasury services |
| dockerfiles/Dockerfile.Treasury.* | Docker build configurations for treasury components |
| docker-compose*.yaml | Service definitions and volume configurations for treasury infrastructure |
| init-scripts/01_create_vultisig_plugin.sql | Database creation script for treasury |
| etc/vultisig/treasury.yml | Treasury-specific configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| logger logrus.FieldLogger, | ||
| verifierApi *verifierapi.VerifierApi, | ||
| ) (*TreasuryPlugin, error) { | ||
| var jobMutex sync.Mutex |
Copilot
AI
Sep 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jobMutex variable is declared locally but never used. It should be removed since the struct field jobMutex is properly initialized with the passed parameter.
docker-compose.yaml
Outdated
| redis-fees: | ||
| condition: service_healthy |
Copilot
AI
Sep 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The treasury-server service depends on redis-fees but should depend on redis-treasury since it uses REDIS_HOST: redis-treasury.
bd14711 to
2e94fe7
Compare
…world structure) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2e94fe7 to
722fca5
Compare
5da5bc6 to
6c03da4
Compare
No description provided.