-
Notifications
You must be signed in to change notification settings - Fork 3
🎨 Load existing batches in case missed as well as creating/loading to… #164
base: fee-v3-api-tx
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements functionality to load existing draft batches that may have been missed during processing, in addition to creating new batches. The changes ensure that any existing draft batches from the verifier API are properly synchronized with the local database before creating new ones.
Key changes:
- Added
loadExistingBatchesfunction to fetch and create missing draft batches from the verifier API - Added
GetDraftBatchesAPI method to retrieve existing draft batches by public key - Enhanced error handling and logging in the batch creation process
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugin/fees/load.go | Adds logic to load existing draft batches and improves error handling in batch creation |
| internal/verifierapi/fees.go | Adds new API method to retrieve draft batches from verifier service |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f31c588 to
15db702
Compare
b67b895 to
4323660
Compare
15db702 to
5b61769
Compare
4323660 to
31e515a
Compare
5b61769 to
56b5b74
Compare
31e515a to
c815da6
Compare
56b5b74 to
028ef1e
Compare
028ef1e to
1cec5d5
Compare
…gether