-
Notifications
You must be signed in to change notification settings - Fork 3
⚡️ Update TX and api code #163
base: fees-v3-db
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the fee collection system from a run-based architecture to a batch-based architecture, streamlining the fee processing workflow and API interactions.
- Replaces the multi-table fee run system with a simplified fee batch approach
- Updates transaction handling to work with individual fee batches instead of grouped fee runs
- Modernizes the verifier API integration with new batch-oriented endpoints
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| storage/postgres/fees.go | Replaces fee run CRUD operations with fee batch operations, simplifying database interactions |
| storage/db.go | Updates database interface to use fee batch methods instead of fee run methods |
| plugin/fees/transaction.go | Refactors transaction processing to handle individual fee batches with improved error handling |
| plugin/fees/post_tx.go | Updates post-transaction processing to work with fee batches instead of fee runs |
| plugin/fees/load.go | Simplifies fee loading by creating batches directly instead of managing runs and individual fees |
| internal/verifierapi/verifierapi.go | Adds HTTP method helper functions for PUT requests |
| internal/verifierapi/fees.go | Replaces fee collection API with new batch creation and management endpoints |
| internal/types/fees.go | Replaces FeeRun and Fee types with simplified FeeBatch type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
413e858 to
be40a87
Compare
b67b895 to
4323660
Compare
be40a87 to
717d8ae
Compare
4323660 to
31e515a
Compare
31e515a to
c815da6
Compare
No description provided.