Fixed mouse not respecting slider's info.step.#80
Open
ActivexDiamond wants to merge 1 commit intovrld:masterfrom
Open
Fixed mouse not respecting slider's info.step.#80ActivexDiamond wants to merge 1 commit intovrld:masterfrom
ActivexDiamond wants to merge 1 commit intovrld:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sliders don't respect their
info.stepwhen dragged by the mouse.The first new line rounds
valueto the nearest step.The second new line also rounds
fractionto the nearest step which is used for drawing. Skipping this line means the slider follows the mouse while being dragged but snaps back on release (the value is still always snapped).The
+0.5is used to round it to the nearest value, removing it will always round down.value_changedis only updated if the value is actually changed; dragging the mouse less thaninfo.step/2will not cause an update.