Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI build issues by removing the legacy Makefile build system and updating the AMBuild configuration to correctly reference Source SDK library paths and build definitions across different platforms and architectures.
Key changes:
- Removes the outdated Makefile build system that was incompatible with current CI environments
- Updates AMBuild library paths to match current Source SDK structure (e.g.,
lib/public/x86instead oflib/public/linux32) - Simplifies CI workflow by removing deprecated OS versions and streamlining artifact upload conditions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Makefile | Removes entire legacy Makefile that was causing CI build failures |
| AMBuildScript | Updates library paths and build definitions to match current Source SDK structure for Linux, Windows, and macOS builds |
| .github/workflows/ci.yml | Removes outdated OS versions (ubuntu-20.04, windows-2019) and simplifies artifact upload conditions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.