This repository was archived by the owner on Jul 27, 2018. It is now read-only.
Rectified the error with MCB in dynamic selection#36
Open
va26 wants to merge 1 commit intoviisar:masterfrom
Open
Rectified the error with MCB in dynamic selection#36va26 wants to merge 1 commit intoviisar:masterfrom
va26 wants to merge 1 commit intoviisar:masterfrom
Conversation
In line 95 the earlier code was checking the 'if' condition between `score[best_i]` and `score[best_j]` and it was giving an error as 'best_j' was not defined. Since line 94 was using 'best_j_score' so I changed the variable name from 'best_j' to 'best_j_score'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In line 95 the earlier code was checking the
if conditionbetweenscore[best_i]andscore[best_j]and it was giving an error asbest_jwas not defined. Since line 94 was usingbest_j_scoreso I changed the variable name frombest_jtobest_j_score.