Merged
Conversation
acmorrow
approved these changes
Jan 29, 2026
Member
acmorrow
left a comment
acmorrow
left a comment
There was a problem hiding this comment.
LGTM. I spent a few minutes thinking about whether there was a better way to express this, but all of them would require breaking changes. I think this is the cleanest way forward.
| optional double max_vel_degs_per_sec = 1; | ||
| // Maximum allowable acceleration of an arm joint, in degrees per second squared | ||
| // Maximum allowable acceleration of an arm joint, in degrees per second squared. | ||
| // ignopred when max_acc_degs_per_sec2_joints is set. |
…s-should-allow-vector-valued
npmenard
added
the
ready-for-protos
npmenard
removed
the
ready-for-protos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ended up adding them as separate fields so that there is no breaking changes. I am tempted declare the original fields as deprecated and allow the new fields to be 1 or N.