fix(board): use enable_i2c in place of turn_i2c_on#80
Merged
HipsterBrown merged 1 commit intoviam-modules:mainfrom Dec 16, 2025
Merged
fix(board): use enable_i2c in place of turn_i2c_on#80HipsterBrown merged 1 commit intoviam-modules:mainfrom
HipsterBrown merged 1 commit intoviam-modules:mainfrom
Conversation
IanWhalen
approved these changes
Dec 16, 2025
Contributor
IanWhalen
left a comment
IanWhalen
left a comment
There was a problem hiding this comment.
Approving from an interface perspective. Have to leave it to John or someone else to approve the code.
Collaborator
|
I reviewed the code - LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README documents a field called
enable_i2cunder theboard_settingsconfig for the Raspberry Pi board modules. The code was actually usingturn_i2c_on. Rather than updating the README, I chose to update the code to use the better name.