chore: add husky pre-commit hook with lint-staged#660
Open
hydrosquall wants to merge 1 commit intovega:masterfrom
Open
chore: add husky pre-commit hook with lint-staged#660hydrosquall wants to merge 1 commit intovega:masterfrom
hydrosquall wants to merge 1 commit intovega:masterfrom
Conversation
Enable formatting issues to be automatically handled locally instead of only erroring in CI, reducing wasted CI minutes. Related to vega/vega#4237 Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
9 tasks
domoritz
reviewed
Feb 9, 2026
| @@ -0,0 +1 @@ | |||
| npx lint-staged && npm test | |||
Member
There was a problem hiding this comment.
Wouldn't running tests slow down commits significantly? I am okay with linting but would be hesitant about running tests in precommit unless we have a way to only run affected tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds pre-commit hooks to catch formatting issues locally before CI, reduce wasted CI minutes, and ensure consistent code style across the codebase (related to vega/vega#4237).
Changes
huskyfrom v7.0.0 to v9.1.7 for git hooks managementlint-stagedfrom v10.0.3 to v16.2.7 to run linters only on staged filesnpx lint-staged && npm test"prepare": "husky"script to auto-initialize hooks onnpm installeslint --fixon*.{js,ts,tsx,mjs,cjs}files.gitignoreto exclude.claude/directoryTesting
npm installto verify the prepare script initializes husky